-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundle tests to use IP of service to avoid cluster domain rules #3431
Conversation
Hi @pierretasci. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Seems simple and effective to me :) /lgtm |
/assign @afrittoli @vdemeester @imjasonh For second set of eyes 🙏 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Fixes a regression (#3429) introduced in the Tekton Bundle tests that depended on accessing the in-cluster registry via the
.cluster.local
DNS syntax. This was to workaround a go-containerregistry limitation which automatically treats.local
addresses asHTTP
. Instead, this change uses the Service's IP in the cluster which go-containerregistry also recognizes as a situation where it should automatically useHTTP
.In addition, categorize the changes you're making using the "/kind" Prow command, example:
/kind failing-test
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes