Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Fix TaskRunSpec overrides when empty 🗜 #3441

Merged
merged 1 commit into from
Oct 23, 2020
Merged

[cherry-pick] Fix TaskRunSpec overrides when empty 🗜 #3441

merged 1 commit into from
Oct 23, 2020

Commits on Oct 23, 2020

  1. Fix TaskRunSpec overrides when empty 🗜 

    In case of TaskRunSpec being present on a PipelineRun, we override the
PipelineTask PodTemplate and ServiceAccount blindly, even if those
values are empty (empty string, nil point)

This fixes this behavior by overriding PodTemplate and/or
ServiceAccountName only when they are not empty values.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
(cherry picked from commit 695d117)
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    @vdemeester
    vdemeester committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    fa7aa64 View commit details
    Browse the repository at this point in the history