Include message on reason-mismatch failures #3448
Conversation
tekton-robot
added
release-note-none
|
/assign @afrittoli @vdemeester @imjasonh |
|
Here's an example of the not-very-useful message I see today 🤣 |
|
Retry test, not sure how my change could have made it fail this way so... /retest |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
Changes
This is a small improvement to the error message printed when a test fails due to a mismatched condition "reason". The change is to also include the "message", which often contains significantly more detailed information than the "reason".
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes