Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error path through test. #3474

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Conversation

mattmoor
Copy link
Member

In a downstream flake I saw this error:

timeout_test.go:234: Error waiting for TaskRun pipeline-task-timeout-hdwboxrg-pipelinetask1-2tqsx to be running: %!s(<nil>)

This fixes the format string, and corrects what is likely a bug where err isn't properly set when printed.

/kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

/assign @afrittoli @vdemeester @imjasonh

In a downstream flake I saw this error:
```
timeout_test.go:234: Error waiting for TaskRun pipeline-task-timeout-hdwboxrg-pipelinetask1-2tqsx to be running: %!s(<nil>)
```

This fixes the format string, and corrects what is likely a bug where `err` isn't properly set when printed.
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 30, 2020
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 30, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2020
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2020
@tekton-robot tekton-robot merged commit 9b15dc2 into tektoncd:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants