Use Webhook v1 APIs #3486
Merged
Use Webhook v1 APIs #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
Use `admissionregistration.k8s.io/v1` instead of `admissionregistration.k8s.io/v1beta1` for our admission controllers (webhooks). This change is mainly due to the fact that `apiextensions.k8s.io/v1beta1` CRDs are deprecated and will be unavailable at some point. ``` Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition ``` Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
update-webhook-to-v1
branch
from
ecf488a
to
fe6e612
Compare
ghost
approved these changes
Nov 2, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Nice, we need to port this to triggers too. /lgtm |
dibyom
added a commit
to dibyom/triggers
that referenced
this pull request
Nov 17, 2020
`apiextensions.k8s.io/v1beta1` is deprecated in Kubernetes v1.16. This change moves our webhooks to use `apiextensions.k8s.io/v1` instead. Port of tektoncd/pipeline#3486 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
4 tasks
tekton-robot
pushed a commit
to tektoncd/triggers
that referenced
this pull request
Nov 18, 2020
`apiextensions.k8s.io/v1beta1` is deprecated in Kubernetes v1.16. This change moves our webhooks to use `apiextensions.k8s.io/v1` instead. Port of tektoncd/pipeline#3486 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use
admissionregistration.k8s.io/v1instead ofadmissionregistration.k8s.io/v1beta1for our admissioncontrollers (webhooks).
This change is mainly due to the fact that
apiextensions.k8s.io/v1beta1CRDs are deprecated and will beunavailable at some point.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/kind misc
/cc @tektoncd/core-maintainers
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes