Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb the "TEKTON_RESOURCE_NAME" env var into the cluster and PR reso… #3555

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Nov 23, 2020

…urces.

Changes

As part of TEP-0025 (hermetic builds), we need to know which containers/steps are part
of the "Tekton system" and which ones are part of the Task definition. This PR adds
the TEKTON_RESOURCE_NAME environment variable to the injected copy containers.

This variable is already used by several of the existing resources (git, image).

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [ X] Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

The TEKTON_RESOURCE_NAME environment variable is now set on the injected PR and cluster resource containers.

…urces.

As part of TEP-0025 (hermetic builds), we need to know which containers/steps are part
of the "Tekton system" and which ones are part of the Task definition. This PR adds
the TEKTON_RESOURCE_NAME environment variable to the injected copy containers.

This variable is already used by several of the existing resources (git, image).

/kind feature
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 23, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 23, 2020
@bobcatfish
Copy link
Collaborator

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@tekton-robot tekton-robot merged commit a1b125b into tektoncd:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants