Fix duplicate TaskRuns when Pipeline/PipelineRun labels are changed #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
|
@GregDritschler I think we need a release-note entry though 👼 |
vdemeester
approved these changes
Nov 24, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
approved
afrittoli
reviewed
Nov 24, 2020
| t.Fatalf("unexpected error when updating status: %v", err) | ||
| } | ||
|
|
||
| // The label update triggers another reconcile. Depending on timing, the PipelineRun passed to the reconcile may or may not |
imjasonh
reviewed
Nov 24, 2020
|
/hold |
tekton-robot
added
the
do-not-merge/hold
…re changed The PipelineRun reconciler may be handed a PipelineRun that does not have a previous status update containing the names of TaskRuns it created. The PipelineRun reconciler attempts to deal with this by looking at the TaskRun lister cache for TaskRuns associated with the PipelineRun that are missing from the status and adding them. It uses the PipelineRun's labels to find them. If the user changes the PipelineRun's labels (or the Pipeline's labels which are propagated to the PipelineRun) while the pipeline is running, it may cause the code to not find existing TaskRuns and as a result it may duplicate them.
GregDritschler
force-pushed
the
issue3126
branch
from
1b2617c
to
b6aa6ee
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm Thanks for digging into this @GregDritschler ! |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3126
The PipelineRun reconciler may be handed a PipelineRun that does not have a previous status update containing the names of TaskRuns it created. The PipelineRun reconciler attempts to deal with this by looking at the TaskRun lister cache for TaskRuns associated with the PipelineRun that are missing from the status and adding them. It uses the PipelineRun's labels to find them. If the user changes the PipelineRun's labels (or the Pipeline's labels which are propagated to the PipelineRun) while the pipeline is running, it may cause the code to not find existing TaskRuns and as a result it may duplicate them.
Changes
The reconciler is changed to use only the
tekton.dev/pipelineRunlabel when listing TaskRuns associated with the PipelineRun./kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes