Allow passing in Finally Tasks to TestIsSkipped

[jerop]

Changes

Currently, TestIsSkipped defaults to Finally Tasks being empty in the
PipelineRunFacts

In this change, we add allow passing in Finally Tasks in the test cases
in TestIsSkipped

This would be useful for testing skipping of Finally Tasks when their
WhenExpressions evaluate to false, which would be supported in #3738

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jerop
You can assign the PR to them by writing /assign @jerop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pritidesai]

Currently, TestIsSkipped defaults to Finally Tasks being empty in the PipelineRunFacts

Hey @jerop, the finally tasks can not have any dependencies and that's why the graph build function was updated to separate the dependencies from that function in PR - #3583.

[pritidesai]

Dependencies are set to help schedule that task and making sure all the dependencies are executed before scheduling it. finally tasks are always scheduled after all dag tasks done.

[jerop]

Hey @jerop, the finally tasks can not have any dependencies and that's why the graph build function was updated to separate the dependencies from that function in PR - #3583.

thanks @pritidesai -- I've added dagFromFinallyTasks to build dag from finally tasks in pipelinerunresolution_test.go

pipeline/pkg/reconciler/pipelinerun/resources/pipelinerunresolution_test.go

Lines 673 to 679 in f20b192

	func dagFromFinallyTasks(state PipelineRunState) (*dag.Graph, error) {
	fpts := []v1beta1.PipelineTask{}
	for _, rprt := range state {
	fpts = append(fpts, *rprt.PipelineTask)
	}
	return dag.Build(v1beta1.PipelineTaskList(fpts), map[string][]string{})
	}