-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs and examples for Windows #4138
Conversation
A new markdown file has been added to document Windows usage in Tekton.
Hi @aiden-deloryn. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @dlorenc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retest |
879befa
to
de3f2c9
Compare
/retest |
The examples actually get run as part of tests, we probably don't have a Windows node in our test clusters to run these on. |
@dlorenc Aren't the examples under It seems the failed tests are due to linting / white-space errors:
|
Some examples have been added to demonstrate how to schedule TaskRuns and PipelineRuns on a Windows node using node selectors and node affinity constraints.
de3f2c9
to
b9eca13
Compare
They don't run as part of the test (not applied to the cluster, …), but they still get "validated" by the linters 😝 |
That does appear to be the case. Thanks for the confirmation 😄 The tests succeeded after I fixed the linting errors. Please let me know if there is anything else I need to change. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
A new markdown file has been added to document Windows usage in Tekton.
Some examples have been added to demonstrate how to schedule TaskRuns
and PipelineRuns on a Windows node using node selectors and node
affinity constraints.
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes