Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "fail" to "stopAndFail" 🧐 #4151

Merged
merged 1 commit into from
Aug 13, 2021

Commits on Aug 12, 2021

  1. Change "fail" to "stopAndFail" 🧐

    This commit proposes changes the wording of the `fail` option for
    `onError` from `fail` to make it more explicitly clear that this option
    (which is the default behavior when `onError` is not specified) will
    both cause the Task to fail AND stop execution of any subsequent steps.
    
    This change doesn't propose changing any of the described functionality,
    just the value of the field.
    
    Change to the TEP should be approved before this is merged
    (tektoncd/community#497) and if we go ahead with
    it we should do a patch release ASAP to minimize user impact - that
    being said, this change impacts the default value of the field which
    users are unlikely to specify explicitly - users are much more likely to
    start using `onError: continue` and for them there would be no impact.
    bobcatfish committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    e3b7bee View commit details
    Browse the repository at this point in the history