Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller flag to turn off built-in resolution #4168

Merged
merged 1 commit into from Sep 14, 2021
Merged

Add controller flag to turn off built-in resolution #4168

merged 1 commit into from Sep 14, 2021

Commits on Sep 14, 2021

  1. Add controller flag to turn off built-in resolution

    We're currently trying to work out what the best way forward for TEP-0060
    (remote resolution) is for Tekton Pipelines. As part of that we're
    creating a controller in the experimental repo that we can use to test out
    a bunch of the Alternatives from the TEP and figure out what works best
    in terms of implementation and DX.
    
    Right now the experimental controller would race with the Pipelines controllers
    since they're all going to try and "resolve" any taskRef in Taskruns and
    PipelineRuns.
    
    This commit adds a flag to the pipelines controller that explicitly switches
    off resolution performed by the taskrun and pipelinerun reconcilers. This gives
    us just enough room to perform resolution out-of-band and try out some of the
    alternatives.
    
    When the `-experimental-disable-in-tree-resolution` flag is set the taskrun
    and pipelinerun controllers will ignore taskruns and pipelineruns that don't
    have `status.taskSpec` or `status.pipelineSpec` populated.
    Scott committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    1b2783a View commit details
    Browse the repository at this point in the history