Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest knative.dev/pkg #4170

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

mattmoor
Copy link
Member

This pulls in some code-generation changes, and I wanted to make sure it didn't break Tekton.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

This pulls in some code-generation changes, and I wanted to make sure it didn't break Tekton.

/kind cleanup
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 18, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2021
@mattmoor
Copy link
Member Author

cc @n3wscott who reviewed the upstream change to PKG

@n3wscott
Copy link
Contributor

/lgtm

This is updating the codegen from knative/pkg updates from knative/pkg#2210.

@tekton-robot
Copy link
Collaborator

@n3wscott: changing LGTM is restricted to collaborators

In response to this:

/lgtm

This is updating the codegen from knative/pkg updates from knative/pkg#2210.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@dlorenc
Copy link
Contributor

dlorenc commented Aug 18, 2021

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@mattmoor
Copy link
Member Author

/retest

Looks like a flake

@tekton-robot tekton-robot merged commit 67b318b into tektoncd:main Aug 18, 2021
@mattmoor mattmoor deleted the latest-pkg branch August 18, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants