-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to lookup cached entrypoint by digest, if possible #4188
Conversation
Today, when the step's image is not specified by digest (i.e., most of the time), we issue an image pull to get the image's entrypoint, then cache it. This means that when the step isn't specified by digest (i.e., most of the time) we hit the remote registry, and can hit DockerHub's rate limits. With this change, we'll issue a HEAD request to the registry to first lookup the digest of the image, then see if we already have the entrypoint cached by that digest. If the HEAD request fails or the entrypoint isn't found by image digest, we proceed as normal with the image pull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Worth noting: if the image is a multi-arch image (like So this is likely not a full solution to the problem, but should help in the case of single-platform images. We can't seem to resolve index->image (by platform) without a remote |
/lgtm nice! |
/lgtm |
Today, when the step's image is not specified by digest (i.e., most of the
time), we issue an image pull to get the image's entrypoint, then cache
it. This means that when the step isn't specified by digest (i.e., most
of the time) we hit the remote registry, and can hit DockerHub's rate
limits.
With this change, we'll issue a HEAD request to the registry to first
lookup the digest of the image, then see if we already have the
entrypoint cached by that digest. If the HEAD request fails or the
entrypoint isn't found by image digest, we proceed as normal with the
image pull.
/kind feature
Fixes #4187
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes