Bump golangci-lint to v1.42.0 from v1.30.0. #4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the resulting lint errors, and a few of the resulting lint warnings. One of the main linters we use (golint) is now deprecated. The replacement is known as revive, and golangci-lint displays a warning about this now. Unfortunately quite a few lint warnings appear during that update, so I'm doing it in a few pieces. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
tekton-robot
added
release-note-none
tekton-robot
added
the
size/S
dlorenc
added a commit
to dlorenc/plumbing
that referenced
this pull request
Sep 1, 2021
This updates the version of golangci-lint installed in our presubmit images. This accompanies tektoncd/pipeline#4206, which should make tests pass for tektoncd/pipeline with this update. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
dlorenc
added a commit
to dlorenc/plumbing
that referenced
this pull request
Sep 1, 2021
This updates the version of golangci-lint installed in our presubmit images. This accompanies tektoncd/pipeline#4206, which should make tests pass for tektoncd/pipeline with this update. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
1 task
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test check-pr-has-kind-label |
tekton-robot
pushed a commit
to tektoncd/plumbing
that referenced
this pull request
Sep 2, 2021
This updates the version of golangci-lint installed in our presubmit images. This accompanies tektoncd/pipeline#4206, which should make tests pass for tektoncd/pipeline with this update. Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
dlorenc
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Sep 2, 2021
This finishes up the switch from the deprecated golint to revive, which is the replacement. This was started in tektoncd#4206. This consisted of one new lint warning, and switching some suppressions to revive from golint. Signed-off-by: Dan Lorenc <dlorenc@google.com>
3 tasks
dlorenc
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Sep 2, 2021
This finishes up the switch from the deprecated golint to revive, which is the replacement. This was started in tektoncd#4206. This consisted of one new lint warning, and switching some suppressions to revive from golint. Signed-off-by: Dan Lorenc <dlorenc@google.com>
dlorenc
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Sep 3, 2021
This finishes up the switch from the deprecated golint to revive, which is the replacement. This was started in tektoncd#4206. This consisted of one new lint warning, switching some suppressions to revive from golint, and fixing some new errors. Signed-off-by: Dan Lorenc <dlorenc@google.com>
tekton-robot
pushed a commit
that referenced
this pull request
Sep 6, 2021
This finishes up the switch from the deprecated golint to revive, which is the replacement. This was started in #4206. This consisted of one new lint warning, switching some suppressions to revive from golint, and fixing some new errors. Signed-off-by: Dan Lorenc <dlorenc@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Also fix the resulting lint errors, and a few of the resulting lint warnings.
One of the main linters we use (golint) is now deprecated. The replacement is known
as revive, and golangci-lint displays a warning about this now.
Unfortunately quite a few lint warnings appear during that update, so I'm doing it in a few pieces.
Signed-off-by: Dan Lorenc lorenc.d@gmail.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes