Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/cloudevents/sdk-go to v2.5.0 #4216

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Sep 6, 2021

Changes

This updates the cloudevents dependency from v2.1.0 to v2.5.0. This is over a year
old and catches us up quite far.

There was one manual change in the cloud_event_controller_test.go file. CloudEvents
changed the string representation of an event, which our tests looked for. This
matches the change to their upstream test: github.com/cloudevents/sdk-go/pull/639.

Signed-off-by: Dan Lorenc lorenc.d@gmail.com

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 6, 2021
@tekton-robot tekton-robot requested review from dibyom and a user September 6, 2021 01:38
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2021
@dlorenc
Copy link
Contributor Author

dlorenc commented Sep 6, 2021

cc @n3wscott to double check the test change

Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, there was a string change in the sdk around 2.2

@tekton-robot
Copy link
Collaborator

@n3wscott: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Sorry, there was a string change in the sdk around 2.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mattmoor
Copy link
Member

mattmoor commented Sep 6, 2021

Looks like you need to run ./hack/update-deps.sh to ensure the patch to apimachinery is applied.

This updates the cloudevents dependency from v2.1.0 to v2.5.0. This is over a year
old and catches us up quite far.

There was one manual change in the cloud_event_controller_test.go file. CloudEvents
changed the string representation of an event, which our tests looked for. This
matches the change to their upstream test: github.com/cloudevents/sdk-go/pull/639.

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
Signed-off-by: Dan Lorenc <dlorenc@google.com>
@dlorenc
Copy link
Contributor Author

dlorenc commented Sep 7, 2021

/test pull-tekton-pipeline-alpha-integration-tests

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
@vdemeester
Copy link
Member

/test check-pr-has-kind-label

@vdemeester
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@tekton-robot tekton-robot merged commit 64b5bbf into tektoncd:main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants