Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping the CI secret sauce 🦕 #4221

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Skipping the CI secret sauce 🦕 #4221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 examples/v1alpha1/taskruns/docker-creds.yaml → ...v1alpha1/taskruns/no-ci/docker-creds.yaml
View file
Open in desktop
File renamed without changes.
0 ...v1alpha1/taskruns/pull-private-image.yaml → ...a1/taskruns/no-ci/pull-private-image.yaml
View file
Open in desktop
File renamed without changes.
0 examples/v1beta1/taskruns/docker-creds.yaml → .../v1beta1/taskruns/no-ci/docker-creds.yaml
View file
Open in desktop
File renamed without changes.
0 .../v1beta1/taskruns/pull-private-image.yaml → ...a1/taskruns/no-ci/pull-private-image.yaml
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions internal/builder/v1beta1/pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added by accident?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that was to make sure it failed before.. so.. yes and no 😛 I can revert 😬

*/

package builder
Expand Down
2 changes: 2 additions & 0 deletions test/pipelinerun_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ func TestPipelineRun(t *testing.T) {
name: "service account propagation and pipeline param",
testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) {
t.Helper()
t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping")
if _, err := c.KubeClient.CoreV1().Secrets(namespace).Create(ctx, getPipelineRunSecret(index, namespace), metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create secret `%s`: %s", getName(secretName, index), err)
}
Expand Down Expand Up @@ -163,6 +164,7 @@ func TestPipelineRun(t *testing.T) {
name: "pipelinerun succeeds with LimitRange minimum in namespace",
testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) {
t.Helper()
t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping")
if _, err := c.KubeClient.CoreV1().LimitRanges(namespace).Create(ctx, getLimitRange("prlimitrange", namespace, "100m", "99Mi", "100m"), metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create LimitRange `%s`: %s", "prlimitrange", err)
}
Expand Down
1 change: 1 addition & 0 deletions test/v1alpha1/pipelinerun_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ func TestPipelineRun(t *testing.T) {
name: "service account propagation and pipeline param",
testSetup: func(ctx context.Context, t *testing.T, c *clients, namespace string, index int) {
t.Helper()
t.Skip("build-crd-testing project got removed, the secret-sauce doesn't exist anymore, skipping")
if _, err := c.KubeClient.CoreV1().Secrets(namespace).Create(ctx, getPipelineRunSecret(index), metav1.CreateOptions{}); err != nil {
t.Fatalf("Failed to create secret `%s`: %s", getName(secretName, index), err)
}
Expand Down