Remove unnecessary replace directives in go.mod #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XS
|
Running /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
The comment previously indicated these `replace`s were necessary for knative v0.20 deps. The knative/pkg deps were recently updated by mattmoor in 8afd156 (and presumably many times since 0.20), and seem to no longer need the `replace`s. Dropping these `replace`s updates our deps: - azure-sdk-for-go dep updates to a package released in Jun 2020, from one released Jan 2020. - we seem to no longer depend on the stackdriver package, so the `replace` was unnecessary. This change was generated by: - remove `replace` directives - `go mod tidy` - `./hack/update-deps.sh` - `go build ./...` to make sure things didn't break 🤞
imjasonh
force-pushed
the
remove-replace
branch
from
203ab2f
to
6df36a1
Compare
|
/test pull-tekton-pipeline-alpha-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
The comment previously indicated these
replaces were necessary for knative v0.20 deps. The knative/pkg deps were recently updated by @mattmoor in 8afd156 (and presumably many times since 0.20), and seem to no longer need thereplaces.Dropping these
replaces updates our deps:replacewas unnecessary.This change was generated by:
replacedirectivesgo mod tidy./hack/update-deps.shgo build ./...to make sure things didn't break 🤞Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes