Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double MaximumBundleObjects and update tests #4899

Merged
merged 1 commit into from
May 31, 2022
Merged

double MaximumBundleObjects and update tests #4899

merged 1 commit into from
May 31, 2022

Conversation

williamlfish
Copy link
Contributor

@williamlfish williamlfish commented May 23, 2022 •
edited
Loading

Changes

Doubling the MaximumBundleObjects from 10 to 20. The official hard limit is 255 ( for oci images ). This feature is currently in alpha and there is a plan to move bundles to beta, but the current limit is very low, and would love to continue testing the use cases for bundles with larger images.

Slack conversation about doubling the max here 😸

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

Should only have user facing changes if a bundle size is larger than the max, the current error will just display the updated value.

Examples of user facing changes:

  • API changes
  • Bug fixes
  • Any changes in behavior
  • Changes requiring upgrade notices or deprecation warnings
NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels May 23, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 23, 2022
@tekton-robot
Copy link
Collaborator

Hi @williamlfish. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 23, 2022
@williamlfish
Copy link
Contributor Author

/assign @dibyom

@pritidesai
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2022
@williamlfish williamlfish mentioned this pull request May 23, 2022
Merged
4 tasks
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022
jerop
jerop reviewed May 31, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the commits and update them to meet the commits standards: https://github.com/tektoncd/community/blob/main/standards.md#commits

Doubling the MaximumBundleObjects from 10 to 20.
a2e2064 
The official hard limit is 255 ( for oci images ), and while testing use cases for bundles
it was noticed the current max is pretty low, and doubling should still ensure very small oci sizes as well as give a little more flexablitliy in testing.

Also updated the tests, so in the future if a change to the max happens, the tests should be g2g with no changes.
@williamlfish williamlfish force-pushed the double-MaxiMaximumBundleObjects branch from a2b8ca1 to a2e2064 Compare May 31, 2022 20:56
jerop
jerop approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerop
Copy link
Member

jerop commented May 31, 2022

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit 0d8b26a into tektoncd:main May 31, 2022
@williamlfish williamlfish deleted the double-MaxiMaximumBundleObjects branch July 25, 2022 02:35
@zregvart zregvart mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@jerop jerop jerop approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@dibyom dibyom

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@williamlfish @tekton-robot @pritidesai @jerop @vdemeester @dibyom