Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0115: Update Git Resolver example to use revision and pathInRepo fields #5238

Merged
merged 1 commit into from
Aug 9, 2022
Merged

TEP-0115: Update Git Resolver example to use revision and pathInRepo fields #5238

merged 1 commit into from
Aug 9, 2022

Conversation

QuanZhang-William
Copy link
Member

@QuanZhang-William QuanZhang-William commented Jul 29, 2022 •
edited
Loading

Part of TEP-0115

Update Git Resolver example to use revision and pathInRepo fields to reflect the changes in TEP-0115: Add git revision resolution suppot in Git Resolver and Add core Reconciler testing and fake resolver framework functions

Changes

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

None

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 29, 2022
@tekton-robot tekton-robot requested review from abayer and dlorenc July 29, 2022 16:27
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2022
@QuanZhang-William QuanZhang-William changed the title Update Git Resolver example to use revision and pathInRepo fields TEP-0110: Update Git Resolver example to use revision and pathInRepo fields Jul 29, 2022
@QuanZhang-William
Copy link
Member Author

/hold until tektoncd/resolution#75 is checked in

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2022
@QuanZhang-William
Copy link
Member Author

/assign @jerop

@QuanZhang-William QuanZhang-William changed the title TEP-0110: Update Git Resolver example to use revision and pathInRepo fields TEP-0115: Update Git Resolver example to use revision and pathInRepo fields Jul 29, 2022
@QuanZhang-William QuanZhang-William force-pushed the tep-0110-update-git-resolver-examples branch 2 times, most recently from ac48bf5 to a0b79c3 Compare July 29, 2022 16:33
@QuanZhang-William
Copy link
Member Author

/assign @jerop

jerop
jerop approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuanZhang-William thank you for making these updates!

Please update the git resolver docs as well (specifically the params it takes): https://github.com/tektoncd/resolution/tree/main/gitresolver#parameters

NIT: there's a typo in you commit message title

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@jerop
Copy link
Member

jerop commented Aug 8, 2022

/hold cancel

tektoncd/resolution#75 is merged

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2022
@jerop
Copy link
Member

jerop commented Aug 8, 2022

@abayer please take a look 🙏🏾

@abayer
Copy link
Contributor

abayer commented Aug 8, 2022

Technically, this should probably wait until there's a release of Resolution, I guess?

@QuanZhang-William QuanZhang-William force-pushed the tep-0110-update-git-resolver-examples branch from a0b79c3 to 13c9df0 Compare August 8, 2022 20:01
@QuanZhang-William
Copy link
Member Author

@QuanZhang-William thank you for making these updates!

Please update the git resolver docs as well (specifically the params it takes): https://github.com/tektoncd/resolution/tree/main/gitresolver#parameters

NIT: there's a typo in you commit message title

Thanks @jerop! I have updated the commit message title. Will send out another PR to update git resolver doc soon.

@QuanZhang-William
Copy link
Member Author

Git Resolver doc updated in PR TEP-0115: Update git resolver doc to use "revision" and "pathInRepo" fields

@QuanZhang-William
Update git resolver example to use "revision" and "pathInRepo" fields
cee1533 
Part of TEP-0115

Update git resolver example to use "revision" and "pathInRepo" fields to reflect the changes in [TEP-0115: Add git revision resolution suppot in Git Resolver](tektoncd/resolution#75) and [Add core Reconciler testing and fake resolver framework functions](tektoncd/resolution#51)
@QuanZhang-William QuanZhang-William force-pushed the tep-0110-update-git-resolver-examples branch from 13c9df0 to cee1533 Compare August 8, 2022 20:57
@jerop
Copy link
Member

jerop commented Aug 8, 2022

Technically, this should probably wait until there's a release of Resolution, I guess?

@QuanZhang-William afaik we don't make releases for tektoncd/resolution - users install the resolvers by using ko apply -f ./gitresolver/config for example -- so don't think that's a blocker

@abayer
Copy link
Contributor

abayer commented Aug 8, 2022

/lgtm

Ok, works for me.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 9, 2022
@tekton-robot tekton-robot merged commit 547d049 into tektoncd:main Aug 9, 2022
@QuanZhang-William QuanZhang-William mentioned this pull request Jun 13, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@abayer abayer Awaiting requested review from abayer

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@abayer abayer

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuanZhang-William @tekton-robot @jerop @abayer