-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify error message for verify-codegen.sh #5256
Clarify error message for verify-codegen.sh #5256
Conversation
It currently says to run both `hack/update-codegen.sh` and `hack/update-openapigen.sh`, but `hack/update-codegen.sh` actually calls `hack/update-openapigen.sh`. So let's make the message actually match all that you need to do. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
/assign @jerop @afrittoli @lbernick |
/retest |
@JeromeJu it seems like you had some issues here with update-codegen not actually running update-openapigen when you expected it to? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/test check-pr-has-kind-label |
@abayer: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
It currently says to run both
hack/update-codegen.sh
andhack/update-openapigen.sh
, buthack/update-codegen.sh
actually callshack/update-openapigen.sh
. So let's make the message actually match all that you need to do./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes