chore: change ghcr.io/distroless/* to distroless.dev/* #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this time, distroless.dev/static simply redirects to ghcr.io/distroless/static, so this is effectively no change. However, we are evaluating renaming the github.com/distroless org to avoid confusion, and in doing so, images at ghcr.io/distroless may be disrupted. Using the distroless.dev redirector gives us flexibility to change the underlying image registry transparently. The redirector code for distroless.dev is open source at https://github.com/chainguard-dev/registry-redirect and we've used it extensively internally for a month or two with no serious issues. Any credentials that are used are not logged or stored by the redirector, and since the image in question is public anyway, any credentials that pass through the redirector have no elevated permissions.
tekton-robot
added
kind/cleanup
|
/test pull-tekton-pipeline-integration-tests |
vdemeester
approved these changes
Aug 19, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time, distroless.dev/static simply redirects to
ghcr.io/distroless/static, so this is effectively no change.
However, we are evaluating renaming the github.com/distroless org to
avoid confusion, and in doing so, images at ghcr.io/distroless may be
disrupted. Using the distroless.dev redirector gives us flexibility to
change the underlying image registry transparently.
The redirector code for distroless.dev is open source at
https://github.com/chainguard-dev/registry-redirect and we've used it
extensively internally for a month or two with no serious issues.
Any credentials that are used are not logged or stored by the
redirector, and since the image in question is public anyway, any
credentials that pass through the redirector have no elevated
permissions.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
PR friction log:
release-notespace shenanigans ❌TestPipelineRunTimeoutfailed on integration tests and alpha integration tests, retried ❌