Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagating object params #5371

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Propagating object params #5371

merged 1 commit into from
Sep 15, 2022

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Aug 24, 2022 •
edited
Loading

Changes

Prior to this, object parameters were not being propagated down the spec during resolution.
After following the same logic applied for propagating parameters in PRs #5291 and #5143, we can not also propagate object params. This PR address issue #5140

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Propagating object params

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 24, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 24, 2022
@chitrangpatel
Copy link
Contributor Author

chitrangpatel commented Aug 24, 2022 •
edited
Loading

/kind feature

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 24, 2022
@chitrangpatel
Copy link
Contributor Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 24, 2022
@chitrangpatel
Copy link
Contributor Author

/assign @chuangw6 @jerop

@tekton-robot
Copy link
Collaborator

@chitrangpatel: GitHub didn't allow me to assign the following users: chuangw6.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @chuangw6 @jerop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel
Copy link
Contributor Author

/assign @chuangw6

@tekton-robot
Copy link
Collaborator

@chitrangpatel: GitHub didn't allow me to assign the following users: chuangw6.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @chuangw6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel
Copy link
Contributor Author

@chuangw6 Please take a look when you can

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 100.0% 94.6% -5.4
pkg/apis/pipeline/v1beta1/task_validation.go 98.1% 98.1% -0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go 100.0% 94.7% -5.3

@chitrangpatel
Copy link
Contributor Author

I will work on getting the coverage to its original value/better tomorrow

@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from 92b77af to ad3248f Compare August 25, 2022 14:25
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.0% 97.5% -0.4
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 100.0% 94.6% -5.4
pkg/apis/pipeline/v1beta1/task_validation.go 98.1% 98.1% -0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go 100.0% 94.7% -5.3

@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from ad3248f to 11faa73 Compare August 25, 2022 14:47
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.0% 97.5% -0.4
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 100.0% 94.6% -5.4
pkg/apis/pipeline/v1beta1/task_validation.go 98.1% 98.1% -0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go 100.0% 94.7% -5.3

@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from 11faa73 to d76d494 Compare August 25, 2022 15:14
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.0% 97.5% -0.4
pkg/apis/pipeline/v1beta1/task_validation.go 98.1% 98.1% -0.0

@jerop
Copy link
Member

jerop commented Aug 25, 2022

/retest

@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from d76d494 to 2525057 Compare August 25, 2022 18:03
@chitrangpatel chitrangpatel mentioned this pull request Aug 25, 2022
Closed
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.0% 97.5% -0.4
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 100.0% 98.7% -1.3
pkg/apis/pipeline/v1beta1/task_validation.go 98.1% 98.1% -0.0

@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from 2525057 to de2beb9 Compare August 25, 2022 18:30
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 98.0% 97.5% -0.4
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 100.0% 98.8% -1.2
pkg/apis/pipeline/v1beta1/task_validation.go 98.1% 98.1% -0.0

@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from 41ce0c1 to ab1440d Compare September 8, 2022 15:06
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.4% 99.4% 0.0
pkg/apis/pipeline/v1/task_validation.go 98.0% 97.6% -0.4
pkg/apis/pipeline/v1/taskrun_validation.go 100.0% 99.2% -0.8
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 100.0% 98.5% -1.5
pkg/apis/pipeline/v1beta1/task_validation.go 98.1% 97.7% -0.4
pkg/apis/pipeline/v1beta1/taskrun_validation.go 100.0% 99.2% -0.8

@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from ab1440d to 1097732 Compare September 8, 2022 15:51
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.4% 99.4% 0.0
pkg/apis/pipeline/v1/task_validation.go 98.0% 97.6% -0.4
pkg/apis/pipeline/v1/taskrun_validation.go 100.0% 99.2% -0.8
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 100.0% 98.5% -1.5
pkg/apis/pipeline/v1beta1/task_validation.go 98.1% 97.7% -0.4
pkg/apis/pipeline/v1beta1/taskrun_validation.go 100.0% 99.2% -0.8

jerop
jerop reviewed Sep 8, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please examples with propagated object params to the docs? existing examples only show propagated string params and it'd be helpful to make it clear that propagated object params are supported too

pkg/apis/pipeline/v1beta1/pipelinerun_validation_test.go Show resolved Hide resolved
@jerop
Copy link
Member

jerop commented Sep 8, 2022

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@jerop: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from 1097732 to 3440e84 Compare September 8, 2022 17:34
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 99.4% 99.4% 0.0
pkg/apis/pipeline/v1/task_validation.go 98.0% 97.6% -0.4
pkg/apis/pipeline/v1/taskrun_validation.go 100.0% 99.2% -0.8
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 100.0% 98.5% -1.5
pkg/apis/pipeline/v1beta1/task_validation.go 98.1% 97.7% -0.4
pkg/apis/pipeline/v1beta1/taskrun_validation.go 100.0% 99.2% -0.8

@chitrangpatel
Copy link
Contributor Author

/hold until #5427 is resolved

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@chuangw6
Copy link
Member

/hold until #5427 is resolved

FYI, #5427 was merged to main.

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2022
@chitrangpatel
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2022
@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from 3440e84 to d23e8d6 Compare September 12, 2022 16:09
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2022
@chitrangpatel
Propagating object params
c126ca2 
Prior to this, object parameters were not being propagated to the spec during resolution. After following the same logic as that for propagating parameters, we can not also propagate object params.
@chitrangpatel chitrangpatel force-pushed the Bugfix-5140-propagating-object-params branch from d23e8d6 to c126ca2 Compare September 12, 2022 16:28
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipeline_validation.go 98.3% 98.4% 0.0
pkg/apis/pipeline/v1/task_validation.go 97.8% 97.4% -0.4
pkg/apis/pipeline/v1/taskrun_validation.go 100.0% 99.2% -0.8
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go 100.0% 98.5% -1.5
pkg/apis/pipeline/v1beta1/task_validation.go 98.0% 97.6% -0.4
pkg/apis/pipeline/v1beta1/taskrun_validation.go 100.0% 99.2% -0.8

@vdemeester vdemeester removed the kind/bug Categorizes issue or PR as related to a bug. label Sep 15, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@vdemeester
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@vdemeester: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerop
jerop reviewed Sep 15, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @chitrangpatel!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@tekton-robot tekton-robot merged commit a11c385 into tektoncd:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuangw6 chuangw6 chuangw6 left review comments

@lbernick lbernick lbernick left review comments

@jerop jerop jerop left review comments

@vdemeester vdemeester vdemeester approved these changes

Assignees

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.40
Development

Successfully merging this pull request may close these issues.
8 participants
@chitrangpatel @tekton-robot @jerop @abayer @chuangw6 @vdemeester @lbernick @pritidesai