Support parameter substitution for resolver params

[abayer]

Changes

Part of #4710

Until we do v1beta1 of ResolutionRequest, it will still have parameters of map[string]string, so we're only doing limited substitution.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[abayer]

/assign @lbernick @jerop @vdemeester @dibyom

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	98.8%	97.8%	-1.0
pkg/reconciler/pipelinerun/resources/pipelineref.go	85.7%	89.2%	3.5
pkg/reconciler/taskrun/resources/apply.go	99.3%	99.3%	0.0
pkg/reconciler/taskrun/resources/taskref.go	83.0%	85.2%	2.2

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lbernick]

I'm a bit confused-- we're allowing substitution of array and object params in resolver ref, but when they're passed to the resolution request we can only do string params? it seems like it would make more sense to not allow array and object params in resolver ref if we can't pass them to resolution request.

[abayer]

Yeah, I'm planning to add support for array/object params to ResolutionRequest in v1beta1, so I debated whether to block them for now or just shrug and only pass on strings. I opted for the latter, since it's fairly short term, but am willing to be persuaded. =)

[lbernick]

what's the timeline for v1beta1? if v1beta1 resolutionrequest won't be in the same release I'd definitely say reject. If they'll be in the same release it would still be good for the commit to be self consistent, but I wouldn't push back as much

[abayer]

what's the timeline for v1beta1? if v1beta1 resolutionrequest won't be in the same release I'd definitely say reject. If they'll be in the same release it would still be good for the commit to be self consistent, but I wouldn't push back as much

So resolution will be fully merged for v0.40, but I plan to let it wait til v0.42 (in November) for v1beta1 to give it a month in the wild to make sure no critical issues pop up. I'll rework this to reject array/object params shortly.

[abayer]

@lbernick Updated!

EDIT: Whoops, gotta do v1 as well.

EDIT AGAIN: And that's done too.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	98.8%	97.8%	-1.0
pkg/reconciler/pipelinerun/resources/pipelineref.go	85.7%	89.2%	3.5
pkg/reconciler/taskrun/resources/apply.go	99.3%	99.3%	0.0
pkg/reconciler/taskrun/resources/taskref.go	83.0%	85.2%	2.2

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/apply.go	98.8%	97.8%	-1.0
pkg/reconciler/pipelinerun/resources/pipelineref.go	85.7%	89.2%	3.5
pkg/reconciler/taskrun/resources/apply.go	99.3%	99.3%	0.0
pkg/reconciler/taskrun/resources/taskref.go	83.0%	85.2%	2.2

[lbernick]

/lgtm