Move the remote resolvers deployment to a separate namespace #5436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abayer
added
the
kind/feature
tekton-robot
added
the
release-note-none
|
/assign @vdemeester |
tekton-robot
added
the
size/XL
|
The following is the coverage report on the affected files.
|
abayer
force-pushed
the
move-resolvers-to-separate-namespace
branch
from
db1ed6a
to
2f1a78c
Compare
|
The following is the coverage report on the affected files.
|
abayer
force-pushed
the
move-resolvers-to-separate-namespace
branch
from
2f1a78c
to
dbb7cd8
Compare
|
The following is the coverage report on the affected files.
|
In https://github.com/tektoncd/community/blob/main/teps/0060-remote-resource-resolution.md#3-create-a-new-tekton-resolution-project, we say: ``` Webhook and controller deployments for ResolutionRequest objects will run in the tekton-remote-resolution namespace by default. The namespace is intentionally separate from tekton-pipelines to allow RBAC that isolates the remote resolution machinery. ``` While the actual `ResolutionRequest` reconciler/webhooks/etc are now part of the core Pipeline controller/webhook deployments, the actual resolvers (i.e., `git`, `hub`, `bundles`) should probably still be moved to a separate namespace from `tekton-pipelines` to properly isolate the actual resolver executions. So let's do that. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
force-pushed
the
move-resolvers-to-separate-namespace
branch
from
dbb7cd8
to
d02afeb
Compare
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In https://github.com/tektoncd/community/blob/main/teps/0060-remote-resource-resolution.md#3-create-a-new-tekton-resolution-project, we say:
While the actual
ResolutionRequestreconciler/webhooks/etc are now part of the core Pipeline controller/webhook deployments, the actual resolvers (i.e.,git,hub,bundles) should probably still be moved to a separate namespace fromtekton-pipelinesto properly isolate the actual resolver executions. So let's do that.Note that no release note is needed, because this should be merged in before the first Pipeline release with remote resolution incorporated into it.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes