Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch remaining clock references to k8s.io/utils/clock #5448

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Switch remaining clock references to k8s.io/utils/clock #5448

merged 1 commit into from
Sep 7, 2022

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Sep 7, 2022

Changes

These references were added after #5413 was opened.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@abayer abayer added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 7, 2022
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 7, 2022
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 7, 2022
@abayer
Copy link
Contributor Author

abayer commented Sep 7, 2022

/assign @jerop @lbernick @pritidesai @afrittoli @vdemeester

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@abayer
Copy link
Contributor Author

abayer commented Sep 7, 2022

/retest

@abayer
Switch remaining clock references to k8s.io/utils/clock
77d96f7 
These references were added after tektoncd#5413 was opened.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer force-pushed the cleanup-stale-clock-references branch from 6aa14bc to 77d96f7 Compare September 7, 2022 17:26
vdemeester
vdemeester approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lbernick,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 79fe314 into tektoncd:main Sep 7, 2022
@Jefftree Jefftree mentioned this pull request Sep 14, 2022
Merged
7 tasks
abayer added a commit to abayer/tektoncd-pipeline that referenced this pull request Sep 14, 2022
@abayer
Fail linting if k8s.io/apimachinery/pkg/util/clock is imported
d92369e 
Instead, suggest using k8s.io/utils/clock or k8s.io/utils/clock/testing.

Prompted by tektoncd#5448 and tektoncd#5494

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer mentioned this pull request Sep 14, 2022
Merged
7 tasks
tekton-robot pushed a commit that referenced this pull request Sep 15, 2022
@abayer @tekton-robot
Fail linting if k8s.io/apimachinery/pkg/util/clock is imported
c5c9d46 
Instead, suggest using k8s.io/utils/clock or k8s.io/utils/clock/testing.

Prompted by #5448 and #5494

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@vdemeester vdemeester

@pritidesai pritidesai

@afrittoli afrittoli

@jerop jerop

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abayer @tekton-robot @vdemeester @lbernick @pritidesai @afrittoli @jerop