-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe Runtime Envs of E2E Tests #5449
Conversation
/approve Could you change the commit message/PR title to reflect that this is just describing the environment for e2e tests? |
Prior to this commit, it is unclear that where the local tests run and the difference between local tests and presubmit/CI tests. It can be hard for people to understand/debug test failures, especially for people who start to contribute to Tekton. This commit enriches the test doc to clarify the difference mentioned above.
67f1a65
to
d504779
Compare
@abayer Oh good catch!! updated. Thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Prior to this PR, it is unclear that where the local tests run and the difference between local tests and presubmit/CI tests. It can be hard for people to understand/debug test failures, especially for people who start to contribute to Tekton.
This PR enriches the test doc to clarify the difference mentioned above.
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes