Add examples for some resolvers #5451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/L
|
/assign @lbernick @jerop @vdemeester |
abayer
force-pushed
the
add-remote-resolution-examples
branch
2 times, most recently
from
ab5d495
to
d27a8aa
Compare
|
would you mind also adding an example of how to replace a clustertask with the cluster resolver here? |
oops! I forgot about that, will do. |
Note that there's no bundles resolver example at all for Pipeline, because I can't find a publicly available bundle containing a Pipeline. Also, the cluster resolvers for both Pipeline and Task are in `no-ci`, since they require an existing `Pipeline`/`Task` in another namespace in the cluster, and I didn't feel comfortable adding a new namespace to those examples. The hub resolver for `Pipeline` are in `no-ci` because they're using https://github.com/tektoncd/catalog/blob/main/pipeline/buildpacks/0.2/buildpacks.yaml, which requires various tasks already be present. For the moment, the git resolver example for `Pipeline` is also in `no-ci`, but the new file ./test/resolvers_yaml/pipeline-in-git.yaml is intended to be used in an updated git resolver example once this is merged and can be referenced in the example. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
force-pushed
the
add-remote-resolution-examples
branch
from
d27a8aa
to
9eb5206
Compare
vdemeester
approved these changes
Sep 8, 2022
tekton-robot
added
the
approved
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note that there's no bundles resolver example at all for Pipeline, because I can't find a publicly available bundle containing a Pipeline. Also, the cluster resolvers for both Pipeline and Task are in
no-ci, since they require an existingPipeline/Taskin another namespace in the cluster, and I didn't feel comfortable adding a new namespace to those examples. The hub resolver example forPipelineis inno-cibecause it's using https://github.com/tektoncd/catalog/blob/main/pipeline/buildpacks/0.2/buildpacks.yaml, which requires various tasks already be present.For the moment, the git resolver example for
Pipelineis also inno-ci, but the new file ./test/resolvers_yaml/pipeline-in-git.yaml is intended to be used in an updated git resolver example once this is merged and can be referenced in the example.Also fixes a mistake I made in
docs/hub-resolver.md./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes