Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the value for APISecretNamespaceKey #5492

Merged
merged 1 commit into from
Sep 14, 2022

Commits on Sep 13, 2022

  1. Fix the value for APISecretNamespaceKey

    Related to tektoncd#5450.
    
    The key for APISecretNamespace in the configmap is named `api-token-secret-namespace`,
    but the value of `APISecretNamespaceKey` in `pkg/resolution/resolver/git/config.go`
    is `api-token-namespace`. This will cause resolver to fail to get API token.
    
    In this PR, we use the correct key name `api-token-secret-namespace`.
    
    Signed-off-by: Chuang Wang <chuangw@google.com>
    chuangw6 committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    b826409 View commit details
    Browse the repository at this point in the history