Add ResolutionRequest v1beta1, without serving yet #5495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abayer
added
the
kind/feature
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/XL
|
The following is the coverage report on the affected files.
|
lbernick
approved these changes
Sep 14, 2022
tekton-robot
added
the
approved
|
@abayer needs a small rebase 🙏🏼 |
This is the first part of moving remote resolution to beta. Here, we add a new `v1beta1` version of `ResolutionRequest`, with conversion, though the new version is neither served nor stored. The difference between the `v1alpha1` and `v1beta1` version is that we're switching from `Parameters`, a `map[string]string`, to `Params`, a `[]pipelinev1beta1.Param`, so that we can end up passing array and object parameters to resolution requests. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
force-pushed
the
unserved-resolution-v1beta1
branch
from
18ca1c0 to
5ee580b
Compare
|
The following is the coverage report on the affected files.
|
|
@vdemeester done! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
part of #4710
This is the first part of moving remote resolution to beta. Here, we add a new
v1beta1version ofResolutionRequest, with conversion, though the new version is neither served nor stored. The difference between thev1alpha1andv1beta1version is that we're switching fromParameters, amap[string]string, toParams, a[]pipelinev1beta1.Param, so that we can end up passing array and object parameters to resolution requests./kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes