Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regexp for ssh #5496

Merged
merged 1 commit into from
Sep 16, 2022
Merged

fix regexp for ssh #5496

merged 1 commit into from
Sep 16, 2022

Conversation

cleverhu
Copy link
Contributor

@cleverhu cleverhu commented Sep 14, 2022 •
edited
Loading

Changes

Fix http url is recognized as SSH.
Fix: #5429

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix regexp for ssh.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 14, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 14, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2022
@tekton-robot
Copy link
Collaborator

Hi @cleverhu. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cleverhu
Copy link
Contributor Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 14, 2022
Yongxuanzhang
Yongxuanzhang reviewed Sep 14, 2022
View reviewed changes
pkg/git/git_test.go Outdated
Comment on lines 116 to 119
{
url: "http://github.com/user/project.git",
want: false,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a redundant case

		{
			url:  "http://github.com/user/project.git",
			want: false,
		},

pkg/git/git_test.go Outdated Show resolved Hide resolved
pkg/git/git.go Outdated Show resolved Hide resolved
@cleverhu cleverhu force-pushed the fix-regexp-for-ssh branch 6 times, most recently from 66314fb to 2d1c6aa Compare September 14, 2022 17:46
Yongxuanzhang
Yongxuanzhang reviewed Sep 14, 2022
View reviewed changes
pkg/git/git.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2022
@Yongxuanzhang
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/git/git.go 67.9% 68.3% 0.5

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 14, 2022
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2022
fix regexp for ssh
6be18e4 
Signed-off-by: cleverhu <shouping.hu@daocloud.io>
@cleverhu
Copy link
Contributor Author

/retest

@cleverhu
Copy link
Contributor Author

/ok-to-test

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/git/git.go 67.9% 68.3% 0.5

@vdemeester
Copy link
Member

/retest

@vdemeester vdemeester added this to the Pipelines v0.40 milestone Sep 15, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@abayer
Copy link
Contributor

abayer commented Sep 16, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2022
@tekton-robot tekton-robot merged commit 34274fb into tektoncd:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

Assignees

@abayer abayer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.40
Development

Successfully merging this pull request may close these issues.

The protocol of 'HTTPS' using other port instead of 443 is recognized as 'SSH'
5 participants
@cleverhu @tekton-robot @Yongxuanzhang @vdemeester @abayer