-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 CRD release #5579
V1 CRD release #5579
Conversation
7c067c0
to
76773da
Compare
ceded64
to
bf126bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please move the v1 migration docs into the docs folder?
Also, this PR needs a release note |
5bed07e
to
a636821
Compare
efa0da9
to
56bae18
Compare
Are we sure 100% we want |
/hold |
/hold cancel |
/retest |
fa55a54
to
d5c57fb
Compare
/retest |
This PR is ready for a final review PTAL @tektoncd/core-maintainers 🙏 Previously this is on hold for adding the |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, chitrangpatel, dibyom, lbernick, XinruZhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit adds the examples test for the v1 CRD. It sets the `served` fields of the CRDs to true.
This commit adds the integration test for v1 CRD upgraded from v1beta1 and tests the conversion by first creating the expected v1beta1 CRD and then requesting the v1 version of it for comparison.
/lgtm I think the last outstanding issue was around errors while handling status conversions - I verified that the both v1beta1 and v1 example pipelineruns run successfully and the status is displayed when using kubectl |
Changes
This commit releases the v1 pipeline CRDs including task, taskrun, pipeline and
piplinerun by the following:
It copies the example tests from v1beta1 with exceptions for those deprecated
fields eg.
resources
. Reference can be found at https://github.com/tektoncd/pipeline/blob/14eba83bf31277dc3f8c91fa798b38e30d0a8e6a/dev/docs/migrating-v1beta1-to-v1.md.served
in v1 CRDs to true.The second commit adds the integration test for v1 CRD:
and then creates v1 CRD with v1Client and requests it by v1beta1client to
compare if the conversion webhook.
Part i & ii of #5541
Fixes: #5627
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes