Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI workspace to Beta #5628

Merged
merged 1 commit into from
Oct 25, 2022
Merged

CSI workspace to Beta #5628

merged 1 commit into from
Oct 25, 2022

Conversation

JeromeJu
Copy link
Member

Changes

This commit removes the alpha feature gate for the csi workspace so that it becomes a beta feature.

Fixes: #5262
/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

CSI workspaces are promoted to beta/stable API

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 11, 2022
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2022
@tekton-robot
Copy link
Collaborator

@JeromeJu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JeromeJu JeromeJu force-pushed the csi-beta branch 2 times, most recently from b11b551 to 505e83e Compare October 12, 2022 16:17
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2022
dibyom
dibyom reviewed Oct 12, 2022
View reviewed changes
docs/install.md Outdated Show resolved Hide resolved
docs/workspaces.md Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1beta1/workspace_validation.go Outdated Show resolved Hide resolved
@dibyom dibyom mentioned this pull request Oct 12, 2022
Closed
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2022
@dibyom
Copy link
Member

dibyom commented Oct 13, 2022

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@dibyom dibyom mentioned this pull request Oct 13, 2022
Merged
7 tasks
@jerop jerop mentioned this pull request Oct 14, 2022
Merged
7 tasks
@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JeromeJu JeromeJu mentioned this pull request Oct 19, 2022
Closed
jerop
jerop approved these changes Oct 24, 2022
View reviewed changes
docs/workspaces.md Outdated Show resolved Hide resolved
@JeromeJu JeromeJu requested review from jerop and removed request for pritidesai and afrittoli October 24, 2022 17:26
@JeromeJu
CSI workspace to Beta
077baa5 
This commit removes the alpha feature gate for the csi workspace so that it
becomes a beta feature.
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, jerop, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dibyom,jerop,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jerop
jerop reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2022
@JeromeJu
Copy link
Member Author

/retest

1 similar comment
@JeromeJu
Copy link
Member Author

/retest

@tekton-robot tekton-robot merged commit f1b6812 into tektoncd:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick left review comments

@jerop jerop jerop approved these changes

@dibyom dibyom dibyom left review comments

@vdemeester vdemeester vdemeester approved these changes

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSI Volumes to beta
7 participants
@JeromeJu @tekton-robot @dibyom @afrittoli @vdemeester @jerop @lbernick