TEP-0114: Migrate the testing Wait Task to reconcile on v1beta1.CustomRun #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XL
tekton-robot
removed
the
kind/feature
|
/kind feature |
tekton-robot
added
the
kind/feature
XinruZhang
force-pushed
the
TEP-0114-Wait-Task-Beta
branch
from
646bf8e
to
40efb29
Compare
jerop
reviewed
Dec 1, 2022
There was a problem hiding this comment.
do you plan to add the example run in another PR? we could add it in this PR then add the example pipeline in the next PR when it's supported in pipeline controller
test/custom-task-ctrls/wait-task-beta/pkg/reconciler/reconciler.go
Outdated
Show resolved
Hide resolved
XinruZhang
force-pushed
the
TEP-0114-Wait-Task-Beta
branch
from
40efb29
to
cdcd280
Compare
As Custom Task Beta version is released, this PR creates a new Wait Task to reconcile on `v1beta1.CustomRun`, with the new condition changes applied.
XinruZhang
force-pushed
the
TEP-0114-Wait-Task-Beta
branch
from
cdcd280
to
1f02d3f
Compare
Thanks @jerop, added it in this PR! |
jerop
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As Custom Task Beta version is released, this PR creates a new Wait Task to reconcile on
v1beta1.CustomRun, with the new condition changes applied./kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Has Docs included if any changes are user facingfunctionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)Release notes contains the string "action required" if the change requires additional action from users switching to the new releaseRelease Notes