Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0114: Add support for PipelineRun reconciler to create CustomRuns #5832

Merged

Commits on Dec 9, 2022

  1. TEP-0114: Add support for PipelineRun reconciler to create CustomRuns

    Modifies the `PipelineRun` reconciler to allow creating `CustomRun`s, rather than `Run`s, if the new `custom-task-version` feature flag is set to `v1beta1`, rather than the default value of `v1alpha1`.
    
    See [TEP-0114](https://github.com/tektoncd/community/blob/main/teps/0114-custom-tasks-beta.md#new-feature-flag-custom-task-version) for more information on the feature flag.
    
    The `Run`-flavored `wait-task` is renamed to `wait-task-alpha` for better clarity.
    
    Also adds a new integration test for using the beta `CustomRun` with the `custom-task-version` feature flag set to `v1beta1`.
    
    Followups needed:
    * Docs updates
    * Deprecation notice on the `custom-task-version` flag
    * After the next release, `test/custom-task-ctrls/wait-task-beta/cmd/controller/main.go` needs to switch to using `tkncontroller.FilterCustomRunRef`
    * And also after that release, `test/custom-task-ctrls/wait-task-beta/pkg/reconciler/reconciler_test.go` needs to switch to using `parse.MustParseCustomRun`
    
    Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
    abayer committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e1eee36 View commit details
    Browse the repository at this point in the history