Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0127: Larger results using sidecar logs - parsing sidecar logs to extract results #5840

Merged
merged 1 commit into from
Dec 14, 2022
Merged

TEP-0127: Larger results using sidecar logs - parsing sidecar logs to extract results #5840

merged 1 commit into from
Dec 14, 2022

Commits on Dec 14, 2022

  1. TEP-0127: Larger results using sidecar logs - parsing logs to extract… 

    … results

This PR addresses a part of TEP-0127 - parsing logs to extract results into the task run CRD.

The taskrun reconciler fetches the logs of the injected sidecar container sidecar-tekton-log-results. The logs are already structured and can be un-marshalled via json. The reconciler parses these logs and adds the results to the task run CRD. If the size of the result is greater than the max-result-size configured by the user then the TaskRun fails with reason TaskRunResultLargerThanAllowedLimit.

`Note`: the e2e test only covers the success case of using sidecar
logs to extract results. This is because the failure cases are already
tested via unit tests.

Before approving this PR, review tektoncd#5834
    @chitrangpatel
    chitrangpatel committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    cc2f6af View commit details
    Browse the repository at this point in the history