Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted linters -- because neatness counts. #5898

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Sorted linters -- because neatness counts. #5898

merged 1 commit into from
Dec 20, 2022

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Dec 20, 2022

Changes

This PR simply sorts the enabled linters for neatness.

There are no functional changes in this PR.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [N/A] Has Docs included if any changes are user facing
  • [N/A] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

There are no functional changes in this PR.

/kind cleanup
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2022
@Yongxuanzhang
Copy link
Member

/lgtm thanks!
One more thought, I noticed that we have added a ref link in the yaml file. Just wonder if it makes sense to add some docs around https://github.com/tektoncd/pipeline/blob/main/DEVELOPMENT.md to tell developers how to run these check locally? So they don't need to fail until they open the PR

@bendory
Copy link
Contributor Author

bendory commented Dec 20, 2022

#5899

@bendory
Copy link
Contributor Author

bendory commented Dec 20, 2022

One more thought, I noticed that we have added a ref link in the yaml file. Just wonder if it makes sense to add some docs around https://github.com/tektoncd/pipeline/blob/main/DEVELOPMENT.md to tell developers how to run these check locally? So they don't need to fail until they open the PR

Great idea!
Added #5900

@bendory
Copy link
Contributor Author

bendory commented Dec 20, 2022

/assign leebernick

@tekton-robot
Copy link
Collaborator

@bendory: GitHub didn't allow me to assign the following users: leebernick.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign leebernick

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bendory
Copy link
Contributor Author

bendory commented Dec 20, 2022

oops!

/assign lbernick

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022
@tekton-robot tekton-robot merged commit 9c5e9ea into tektoncd:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants