Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP074] Remove Pullrequest-init Image #6078

Merged
merged 1 commit into from
Feb 8, 2023
Merged

[TEP074] Remove Pullrequest-init Image #6078

merged 1 commit into from
Feb 8, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jan 31, 2023 •
edited
Loading

Changes

This commit removes the Pullrequest image. It follows up the removal of the Pullrequest PipelineResources.

Part of: #5967
Follows up: #6011

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Pullrequest image is removed. Please migrate off the Pullrequest Image.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 31, 2023
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 31, 2023
@JeromeJu
Copy link
Member Author

JeromeJu commented Jan 31, 2023 •
edited
Loading

TODO:

  • Find the guide for replacing Pullrequest image and link to release note if there are any.

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 31, 2023
@JeromeJu JeromeJu marked this pull request as draft January 31, 2023 16:21
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2023
@JeromeJu JeromeJu force-pushed the rm-pullrequest-image branch from 3a77b32 to 5318b28 Compare January 31, 2023 17:04
@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 31, 2023
@JeromeJu JeromeJu changed the title Remove Pullrequest Image [TEP074] Remove Pullrequest Image Jan 31, 2023
@JeromeJu JeromeJu changed the title [TEP074] Remove Pullrequest Image [WIP][TEP074] Remove Pullrequest Image Jan 31, 2023
@JeromeJu JeromeJu force-pushed the rm-pullrequest-image branch from 4a0da32 to 2942d57 Compare February 2, 2023 17:00
@JeromeJu JeromeJu marked this pull request as ready for review February 2, 2023 17:01
@JeromeJu JeromeJu force-pushed the rm-pullrequest-image branch 2 times, most recently from 8f7748d to 79b2e9f Compare February 3, 2023 15:20
@JeromeJu JeromeJu changed the title [WIP][TEP074] Remove Pullrequest Image [TEP074] Remove Pullrequest Image Feb 3, 2023
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@JeromeJu JeromeJu changed the title [TEP074] Remove Pullrequest Image [TEP074] Remove Pullrequest-init Image Feb 3, 2023
@JeromeJu
Copy link
Member Author

JeromeJu commented Feb 3, 2023

/test tekton-pipeline-unit-tests

@lbernick
Copy link
Member

lbernick commented Feb 3, 2023

Entrypoint flake: #4643

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lbernick,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2023
@JeromeJu JeromeJu force-pushed the rm-pullrequest-image branch from 79b2e9f to 0a9bb4e Compare February 7, 2023 21:01
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2023
@JeromeJu
Remove Pullrequest Image
656ee74 
This commit removes the Pullrequest image. It follows up the removal of
the Pullrequest . It includes the removal of the
coresponding integration tests for the pullrequest-init image.
@JeromeJu JeromeJu force-pushed the rm-pullrequest-image branch from 0a9bb4e to 656ee74 Compare February 7, 2023 21:05
@JeromeJu
Copy link
Member Author

JeromeJu commented Feb 8, 2023

/retest

@lbernick
Copy link
Member

lbernick commented Feb 8, 2023

/lgtm
(since vincent approved)

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@tekton-robot tekton-robot merged commit 57a21f5 into tektoncd:main Feb 8, 2023
@JeromeJu JeromeJu mentioned this pull request Feb 14, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@abayer abayer Awaiting requested review from abayer

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeromeJu @lbernick @tekton-robot @vdemeester