-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature gate check for param array indexing #6120
Conversation
Skipping CI for Draft Pull Request. |
/test all |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
09cc73b
to
7eaddc8
Compare
/test all |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
7eaddc8
to
6b384cb
Compare
hope this can fix #6102 |
/assign @pritidesai |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
If this approach is ok, I can add more cases to test err check to improve test cov |
6b384cb
to
9689dd4
Compare
Yes, thanks! @afrittoli. I lean to merge @pritidesai's #6103 first. I will hold my PR and update this PR to use both alpha&beta check once it is merged |
/hold |
Wondering if alpha feature gate checking would need to be in the release note? Or this is something that shall already been acknowledged before 🤔 |
Sounds good, will add after I rebase |
Before this commit, if alpha feature gate is not enabled, the array indexing params will not be added to string replacements, thus will lead to non-existent variable error. This is confusing to users and doesn't provide correct guidance. This commit adds the check to the array indexing validation. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
c4b0824
to
a83b286
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
@Yongxuanzhang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign Hey Yongxuan, thank you for the PR and for dividing the PR into three, could you please fix the build failure for this PR :) ? |
Yeah I will fix it when we merge the other 2 and rebase the code. This PR is currently held. Sorry I should mention it |
I plan to rebase PR after those 2 merged. But if it is of too much work I will probably open a new one. |
@Yongxuanzhang: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Move to #6280 instead |
Changes
Before this commit, if alpha or beta feature gate is not enabled, the array indexing params will not be added to string replacements, thus will lead to non-existent variable error. This is confusing to users and doesn't provide correct guidance. This commit adds the check to the array indexing validation.
/kind bug
fixes #6102
Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes