Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0118: Added Matrix.Include field in preview mode #6177

Closed
wants to merge 1 commit into from
Closed

TEP-0118: Added Matrix.Include field in preview mode #6177

wants to merge 1 commit into from

Conversation

EmmaMunley
Copy link
Contributor

Changes

TEP-0118 proposed adding include as a new field within matrix

This is the first of several PRs to add the feature to allow specify specific combinations or explicit combinations for Matrix Parameters.

Note: This PR is to only add the new Matrix.Include field and update the documentation in "Preview Mode". No functionality has been added at this time.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • [N/A ] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

API Change: Added Matrix.Include in preview mode (Not yet functional)

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 15, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 15, 2023
@EmmaMunley EmmaMunley changed the title TEP-0118: Added Matrix.Includes fields in preview mode TEP-0118: Added Matrix.Include fields in preview mode Feb 15, 2023
@EmmaMunley EmmaMunley changed the title TEP-0118: Added Matrix.Include fields in preview mode TEP-0118: Added Matrix.Include field in preview mode Feb 15, 2023
@EmmaMunley
Copy link
Contributor Author

/assign @pritidesai

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from pritidesai after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

EmmaMunley
EmmaMunley commented Feb 16, 2023
View reviewed changes
Copy link
Contributor Author

@EmmaMunley EmmaMunley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Priti! I've updated for both v1 and v1beta1.

pkg/apis/pipeline/v1beta1/pipeline_types.go Show resolved Hide resolved
@EmmaMunley EmmaMunley force-pushed the include-in-matrix branch 2 times, most recently from ecd39dc to d082a73 Compare February 16, 2023 19:16
@EmmaMunley
TEP-0118: Added Matrix.Include field in preview mode for v1 and v1bet…
b7d311d 
…a1. Note only the field has been added at this time.
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2023
@tekton-robot
Copy link
Collaborator

@EmmaMunley: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-build-tests b7d311d link true /test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pritidesai
pritidesai reviewed Feb 16, 2023
View reviewed changes
pkg/apis/pipeline/v1beta1/swagger.json
@@ -151,174 +151,7 @@
}
}
},
"v1alpha1.PipelineResource": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes are part of this PR? 🤔 They should not belong here, right?

@EmmaMunley
Copy link
Contributor Author

Having issues with the hack/update-openapigen.sh script to regenerate files so am closing this out and opening a new PR here #6188

@EmmaMunley EmmaMunley closed this Feb 17, 2023
@EmmaMunley EmmaMunley deleted the include-in-matrix branch February 18, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai left review comments

@vdemeester vdemeester Awaiting requested review from vdemeester

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@pritidesai pritidesai

Labels
kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmmaMunley @tekton-robot @pritidesai