[release-v0.41.x] picking up latest changes in knative 1.8 #6201
Conversation
knative.dev/pkg was recently updated to include a performance fix which helped reduced the CPU usage by 61% and memory usage by 44% for huge pipelines. This commit is updating the tekton controllers to include that fix such that our LTS release can take advantage of this performance improvement. The same fix was cherry picked in knative.dev/pkg 1.9. Tekton pipeline was updated to use knative 1.9 post 0.45. We have another PR tektoncd#6194 open to update pipeline controllers. Signed-off-by: pritidesai <pdesai@us.ibm.com>
tekton-robot
added
kind/misc
tekton-robot
added
the
size/S
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
|
/test pull-tekton-pipeline-beta-integration-tests |
|
the beta test failure is constant in all the attempts so far 😞: I am having hard time deciphering the failure but looks like a cluster is being created with 1.24, could that be an issue? 🤔 Also, I checked two latest commits in release-v0.41.x and noticed the
|
The beta integration test was introduced and held to be merged after V1 CRD release, which could be the reason why it was not in v0.41. |
|
As for the cluster versioning tektoncd/plumbing#1348 and tektoncd/plumbing#1332 should be both in the last release, which I am not sure if that should be the case? cc @XinruZhang @vdemeester 🤔 |
|
One more thing I noticed, we are running go 1.19: This might not be causing issue here but our pipelines repo is compliant with 1.18 as par go.mod. |
|
An interesting comparison of logs from beta tests in this PR and one of the recent PRs:
Beta tests from this PR is missing setting up the KIND cluster and running |
The error comes from the param we specified during the container creation |
|
thanks @XinruZhang 👍 I am also wondering why is the GKE being provisioned instead of KIND? |
|
Could it be because this beta env. setting is missing from this branch (release-v0.41.x)? |
|
Do we need to cherry pick this PR which added prow env. for beta tests? |
|
One more follow up PR which we might have to cherry pick? #6031 🤔 |
|
Wondering if there's other modifications we need to cherrypick to ensure our CI works for previous releases. 🤔 |
|
It looks llike we are good to go based on the comparison between this branch with the latest branch: https://gist.github.com/XinruZhang/8a631aaa69457d53b96ce71ca1d5c428 |
Cherrypick PR #6031 and #5737? Any other PRs I am missing to cherrypick? |
oh no, the gist has many more changes 😞 but the larger results was introduced in 0.43 which does not need to be cherrypicked. Also, we do need to cherrypick one more PR - #5726 |
|
So to make 0.41 releasable, we need to cherrypick the following PRs:
Please correct me if I am wrong or add anything I am missing. |
|
I wonder do we need to run |
I think that we should not what it does should be only for those integration tests that require beta gates, so should not be a problem even if it is ran against them 🤔 |
|
Yup, I have been trying to see if it's possible to disable |
SGTM! Thank you @pritidesai ! |
|
Hey @JeromeJu @XinruZhang @vdemeester @lbernick, I have a separate PR opened to fix the CI failure for the The |
|
/retest |
In PR tektoncd#6201, we identified a failure with our CI system. Beta integrations tests are failing in PR tektoncd#6201. Our CI system has been updated to run beta tests but the code base in release-v0.42.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.42.x branch for the tests to work. Cherry picking the following PRs: [upgrade test] Change to Kind cluster and Unfixed upgrade test release version tektoncd#5726 Add prow env for beta integration test tektoncd#5737 Beta Example Tests tektoncd#6031 Signed-off-by: pritidesai <pdesai@us.ibm.com>
In PR tektoncd#6201, we identified a failure with our CI system. Beta integrations tests are failing in PR tektoncd#6201. Our CI system has been updated to run beta tests but the code base in release-v0.42.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.42.x branch for the tests to work. Cherry picking the following PRs: [upgrade test] Change to Kind cluster and Unfixed upgrade test release version tektoncd#5726 Add prow env for beta integration test tektoncd#5737 Beta Example Tests tektoncd#6031 Signed-off-by: pritidesai <pdesai@us.ibm.com>
In PR tektoncd#6201, we identified a failure with our CI system. Beta integrations tests are failing in PR tektoncd#6201. Our CI system has been updated to run beta tests but the code base in release-v0.42.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.42.x branch for the tests to work. Cherry picking the following PRs: [upgrade test] Change to Kind cluster and Unfixed upgrade test release version tektoncd#5726 Add prow env for beta integration test tektoncd#5737 Beta Example Tests tektoncd#6031 Signed-off-by: pritidesai <pdesai@us.ibm.com>
In PR tektoncd#6201, we identified a failure with our CI system. Beta integrations tests are failing in PR tektoncd#6201. Our CI system has been updated to run beta tests but the code base in release-v0.44.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.44.x branch for the tests to work. Cherry picking the following PRs: [upgrade test] Change to Kind cluster and Unfixed upgrade test release version tektoncd#5726 Add prow env for beta integration test tektoncd#5737 Beta Example Tests tektoncd#6031 Running update-codegen using Go 1.19 Signed-off-by: pritidesai <pdesai@us.ibm.com>
In PR tektoncd#6201, we identified a failure with our CI system. Beta integrations tests are failing in PR tektoncd#6201. Our CI system has been updated to run beta tests but the code base in release-v0.44.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.44.x branch for the tests to work. Cherry picking the following PRs: [upgrade test] Change to Kind cluster and Unfixed upgrade test release version tektoncd#5726 Add prow env for beta integration test tektoncd#5737 Beta Example Tests tektoncd#6031 Running update-codegen using Go 1.19 Signed-off-by: pritidesai <pdesai@us.ibm.com>
In PR tektoncd#6201, we identified a failure with our CI system. Beta integrations tests are failing in PR tektoncd#6201. Our CI system has been updated to run beta tests but the code base in release-v0.44.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.44.x branch for the tests to work. Cherry picking the following PRs: [upgrade test] Change to Kind cluster and Unfixed upgrade test release version tektoncd#5726 Add prow env for beta integration test tektoncd#5737 Beta Example Tests tektoncd#6031 Running update-codegen using Go 1.19 Signed-off-by: pritidesai <pdesai@us.ibm.com>
In PR #6201, we identified a failure with our CI system. Beta integrations tests are failing in PR #6201. Our CI system has been updated to run beta tests but the code base in release-v0.42.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.42.x branch for the tests to work. Cherry picking the following PRs: [upgrade test] Change to Kind cluster and Unfixed upgrade test release version #5726 Add prow env for beta integration test #5737 Beta Example Tests #6031 Signed-off-by: pritidesai <pdesai@us.ibm.com>
In PR #6201, we identified a failure with our CI system. Beta integrations tests are failing in PR #6201. Our CI system has been updated to run beta tests but the code base in release-v0.44.x was not updated with necessary changes to run beta tests successfully. We discovered a list of PRs which needs to be cherry picked into release-0.44.x branch for the tests to work. Cherry picking the following PRs: [upgrade test] Change to Kind cluster and Unfixed upgrade test release version #5726 Add prow env for beta integration test #5737 Beta Example Tests #6031 Running update-codegen using Go 1.19 Signed-off-by: pritidesai <pdesai@us.ibm.com>
Changes
This PR is a result of:
knative.dev/pkgwas recently updated to include a performance fix which helped reduced the CPU usage by 61% and memory usage by 44% for huge pipelines. This PR is updating the tekton controllers to include that fix such that our LTS release can take advantage of this performance improvement.The same fix was cherry picked in knative.dev/pkg 1.9. Tekton pipeline was updated to use knative 1.9 post 0.45 in PR #6062. We have another PR #6194 open to update pipeline controllers in the
mainbranch./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes