apply latest knative.dev/pkg 1.9 #6256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
7 tasks
knative.dev/1.9 was updated to include a fix for a performance issue. The changes in knative.pkg include improving reconciler updateStatus performance by eliminating the existing and desired state calculation in none debug mode. The PR which was cherry picked in knative.pkg 1.9: knative/pkg#2678 As part of this commit, this change is applied to all tekton resources reconcilers to take an advantage of this performance fix. Signed-off-by: pritidesai <pdesai@us.ibm.com>
pritidesai
force-pushed
the
cherrypick-knative-1.9
branch
from
04096ea
to
95a4495
Compare
vdemeester
approved these changes
Mar 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We upgraded to
knative/pkg1.9 in #6062.knative.dev/1.9was later updated to include a fix for a performance issue (thank you @rafalbigaj). The changes inknative.pkginclude improving reconcilerupdateStatusperformance by eliminating the existing and desired state calculation in non debug mode.This PR is making sure we update the
knativedependency.This PR is a replacement of #6194.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes