Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hygiene: enable goconst, dogsled linters. #6262

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Hygiene: enable goconst, dogsled linters. #6262

merged 1 commit into from
Mar 3, 2023

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Mar 1, 2023 •
edited
Loading

Changes

There are no expected functional changes in this PR.

Made nominal code changes to adhere to linter standards, specifically more systematic use of
pipeline.*RunControllerName constants.

Context: #5899

/kind cleanup

Submitter Checklist

  • [N/A] Has Docs included if any changes are user facing
  • [N/A] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 1, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2023
@bendory bendory mentioned this pull request Mar 1, 2023
Closed
39 tasks
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
vdemeester
vdemeester reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the name of the contstant could probably be changed (or aliased in that matter, to not break possible downstream usage). CustomRun represent the name of the type, not really the "controller's" name (same for TaskRun and PipelineRun). Especially as it's mostly using in the TypeMeta (versus the actual "controller"'s name code).

@bendory
Copy link
Contributor Author

bendory commented Mar 2, 2023

Note: the name of the constant could probably be changed (or aliased in that matter, to not break possible downstream usage). CustomRun represent the name of the type, not really the "controller's" name (same for TaskRun and PipelineRun). Especially as it's mostly using in the TypeMeta (versus the actual "controller"'s name code).

Thanks, I think this code is more readable.

@bendory
Hygiene: enable goconst, dogsled linters.
61b1533 
There are no expected functional changes in this PR.

Made nominal code changes to adhere to linter standards, specifically
more systematic use of `pipeline.*RunControllerName` constants.

Context: #5899

/kind cleanup

- [N/A] Has [Docs](https://github.com/tektoncd/community/blob/main/standards.md#docs) included if any changes are user facing
- [N/A] Has [Tests](https://github.com/tektoncd/community/blob/main/standards.md#tests) included if any functionality added or changed
- [x] Follows the [commit message standard](https://github.com/tektoncd/community/blob/main/standards.md#commits)
- [x] Meets the [Tekton contributor standards](https://github.com/tektoncd/community/blob/main/standards.md) (including functionality, content, code)
- [x] Has a kind label. You can add one by adding a comment on this PR that contains `/kind <type>`. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
- [x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
- [x] Release notes contains the string "action required" if the change requires additional action from users switching to the new release
Yongxuanzhang
Yongxuanzhang reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/reconciler/pipelinerun/pipelinerun.go
// match their corresponding controller names. Given that it's odd to use a
// "ControllerName" const in describing the type of run, we import these
// constants (for consistency) but rename them (for ergonomic semantics).
const (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@tekton-robot tekton-robot merged commit a025277 into tektoncd:main Mar 3, 2023
@bendory bendory deleted the dogsled branch March 3, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@vdemeester vdemeester vdemeester left review comments

@jerop jerop jerop approved these changes

@abayer abayer Awaiting requested review from abayer

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bendory @tekton-robot @vdemeester @jerop @Yongxuanzhang