-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore timeouts default for v1 #6311
Conversation
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix @JeromeJu!
Please clarify that the defaulting in prs.Timeout was in v1beta1 -- and that it was not was replaced with prs.Timeouts in v1 (so we need to fix the defaulting in v1)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Thank you Jerop, I updated the PR comment. |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
This commit restores the pipelineRun timeouts default for v1.
/lgtm |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/cherry-pick release-v0.44.x |
@JeromeJu: new pull request created: #6556 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
This commit restores the pipelineRun timeouts default for v1.
Previously the pipeline timeout was set by
pipelinerun.spec.timeout
in v1beta1 which has been deprecated.Now it has been replcaed with
pipelinerun.spec.timeouts.pipeline
in v1/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes