Test refactor: separate Task validation tests for propagation #6677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support propagated parameters in inline Task specs, validation of variable usage is skipped for inline Task specs and performed only for referenced Tasks. This commit refactors TestTaskSpecValidateError to split out the test cases which rely on this validation logic from test cases that rely on validation logic that is always performed. Since validation logic for usage of declared variables should always be performed when a Task is created directly (but not always for a Task spec), it updates these tests to validate a Task rather than a Task spec. This refactoring will make cleanup for propagated parameters easier. No functional changes.
tekton-robot
added
release-note-none
chitrangpatel
approved these changes
May 17, 2023
|
/lgtm |
|
/retest |
dibyom
approved these changes
May 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support propagated parameters in inline Task specs, validation of variable usage is skipped for inline Task specs and performed only for referenced Tasks. This commit refactors TestTaskSpecValidateError to split out the test cases which rely on this validation logic from test cases that rely on validation logic that is always performed. Since validation logic for usage of declared variables should always be performed when a Task is created directly (but not always for a Task spec), it updates these tests to validate a Task rather than a Task spec. This refactoring will make cleanup for propagated parameters easier. No functional changes.
/kind cleanup
Partially addresses #6647
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes