Cleanup context-based validation of propagated params/workspaces

[lbernick]

Prior to this commit, a sentinel value was injected into the context to determine what validation to perform for propagated parameters and workspaces. This commit removes the sentinel value and calls validation functions where they are needed. It exports and adds tests for ValidateUsageOfDeclaredParameters so it can be called in the reconciler. No functional changes.

/kind cleanup
Closes #6647

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• n/a Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• n/a Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.7%	-0.0
pkg/apis/pipeline/v1/pipelinerun_validation.go	93.9%	93.9%	-0.0
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.0
pkg/apis/pipeline/v1/taskrun_validation.go	97.8%	97.7%	-0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	99.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	96.9%	96.9%	-0.0
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.2%	-0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.8%	97.8%	-0.0
pkg/reconciler/pipelinerun/pipelinerun.go	89.2%	89.2%	-0.0
pkg/reconciler/taskrun/taskrun.go	85.0%	84.5%	-0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.7%	-0.0
pkg/apis/pipeline/v1/pipelinerun_validation.go	93.9%	93.9%	-0.0
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.0
pkg/apis/pipeline/v1/taskrun_validation.go	97.8%	97.7%	-0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	99.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	96.9%	96.9%	-0.0
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.2%	-0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.8%	97.8%	-0.0
pkg/reconciler/pipelinerun/pipelinerun.go	89.2%	89.2%	-0.0
pkg/reconciler/taskrun/taskrun.go	85.0%	84.5%	-0.5

[chitrangpatel]

Thanks for this cleanup!

[chitrangpatel]

/lgtm

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.7%	-0.0
pkg/apis/pipeline/v1/pipelinerun_validation.go	93.9%	93.9%	-0.0
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.0
pkg/apis/pipeline/v1/taskrun_validation.go	97.8%	97.7%	-0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	99.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	96.9%	96.9%	-0.0
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.2%	-0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.8%	97.7%	-0.0
pkg/reconciler/pipelinerun/pipelinerun.go	89.2%	89.2%	-0.0
pkg/reconciler/taskrun/taskrun.go	85.0%	84.5%	-0.5

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.7%	-0.0
pkg/apis/pipeline/v1/pipelinerun_validation.go	93.9%	93.9%	-0.0
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.0
pkg/apis/pipeline/v1/taskrun_validation.go	97.8%	97.7%	-0.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	99.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	96.9%	96.9%	-0.0
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.2%	-0.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.8%	97.7%	-0.0
pkg/reconciler/pipelinerun/pipelinerun.go	89.2%	89.2%	-0.0
pkg/reconciler/taskrun/taskrun.go	85.0%	84.5%	-0.5

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chitrangpatel]

/lgtm