Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate beta features only when v1 Tasks and Pipelines are defined #6701

Merged
merged 1 commit into from
May 30, 2023

Commits on May 30, 2023

  1. Validate beta features only when v1 Tasks and Pipelines are defined

    Currently, validation differs between api versions: when beta features are used in v1 APIs,
    "enable-api-fields" must be set to "alpha" or "beta", but when beta features are used in beta APIs,
    "enable-api-fields" may be set to "alpha", "beta", or "stable".
    
    We also validate the specs of referenced Tasks or Pipelines in the TaskRun/PipelineRun reconciler.
    This presents a problem when referencing a Task or Pipeline declared locally, since the Task or Pipeline may be converted into a different API version when it's stored.
    
    This commit moves validation for beta features to apply only to Tasks and Pipelines when they are created or updated,
    and not called when a Task spec or Pipeline spec is validated.
    
    This commit will allow us to swap the storage version of our API without user-facing impact.
    Separately, we plan to decouple feature versioning from API versioning, as it is a better long-term solution.
    
    This commit contains no expected functional changes, since the TaskRun and PipelineRun reconcilers do not
    currently validate that"enable-api-fields" is set to "alpha" or "beta" when beta features are used in
    referenced Tasks or Pipelines.
    
    This validation will be added for v1 remote Tasks and Pipelines in a separate commit.
    lbernick committed May 30, 2023
    Configuration menu
    Copy the full SHA
    412fbce View commit details
    Browse the repository at this point in the history