Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PipelineRun and Run yamls in conversion_test to avoid flake #6714

Merged
merged 1 commit into from
May 30, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented May 24, 2023

Changes

This commit refactors the yamls in the conversion test to aovid flake
where the TaskRun and the PipelineRun could run forever:

  • remove the resources related codes
  • change the workspace usage that are not present
  • updates the params specifications

fixes: #6672
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels May 24, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 24, 2023
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2023
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task looks simple enough that it should not take 5 mins to run.
Have we looked into why the task is timing out? Anything in the status/logs of the failing run or the controller logs?

@JeromeJu
Copy link
Member Author

This task looks simple enough that it should not take 5 mins to run. Have we looked into why the task is timing out? Anything in the status/logs of the failing run or the controller logs?

I think from the build logs in the issue https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6663/pull-tekton-pipeline-alpha-integration-tests/1658558758315364352, it has been reconciled Succeeded and waited timeout:

    stream.go:305: I 20:02:20.740 tekton-pipelines-controller-66b8bdc479-g4zqb [github.com.tektoncd.pipeline.pkg.reconciler.taskrun.Reconciler] [arendelle-fqvtt/pipeline-run-c-r-d-conversion-wgsdqpcl-fetch-secure-data] Reconcile succeeded
    conversion_test.go:910: Failed waiting for v1 pipelineRun done: "pipeline-run-c-r-d-conversion-wgsdqpcl" failed

This seems to me that it has been timed out for waiting in 60s if I am not mistaken by the last part of the logs 🤔 .

@dibyom
Copy link
Member

dibyom commented May 25, 2023

This seems to me that it has been timed out for waiting in 60s if I am not mistaken by the last part of the logs

Sure, that's a good start but we should look into why the pipeline is timing out waiting for 60s - the actual task only seems to echo hello so its really weird that it will take a entire minute to finish running.

Some other oddities I noticed in the pipeline is that we are referencing a workspace with a secret but that is never used (is the secret even present?). Also, some of the tasks/pipelines have references to pipeline resources - shouldn't they fail to get created?

This commit refactors the yamls in the conversion test to aovid flake
where the TaskRun and the PipelineRun could run forever:
- remove the `resources` related codes
- change the workspace usage that are not present
- updates the params specifications
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2023
@JeromeJu JeromeJu changed the title Fix flakes by increasing timeouts in conversion e2e tests Refactor PipelineRun and Run yamls in conversion_test to avoid flake May 26, 2023
@JeromeJu
Copy link
Member Author

This seems to me that it has been timed out for waiting in 60s if I am not mistaken by the last part of the logs

Sure, that's a good start but we should look into why the pipeline is timing out waiting for 60s - the actual task only seems to echo hello so its really weird that it will take a entire minute to finish running.

Some other oddities I noticed in the pipeline is that we are referencing a workspace with a secret but that is never used (is the secret even present?). Also, some of the tasks/pipelines have references to pipeline resources - shouldn't they fail to get created?

Thanks @dibyom , I've updated the PR, I've mistaken that it could be longer than 60s while having the previous functionalities before we remove all the resources. I have validated the taskrun and pipelineruns yaml respectively.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@tekton-robot tekton-robot merged commit 7a621fe into tektoncd:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestPipelineRunCRDConversion is flake
4 participants