-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PipelineRun and Run yamls in conversion_test to avoid flake #6714
Conversation
f1972f6
to
28885c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This task looks simple enough that it should not take 5 mins to run.
Have we looked into why the task is timing out? Anything in the status/logs of the failing run or the controller logs?
I think from the build logs in the issue https://prow.tekton.dev/view/gs/tekton-prow/pr-logs/pull/tektoncd_pipeline/6663/pull-tekton-pipeline-alpha-integration-tests/1658558758315364352, it has been reconciled Succeeded and waited timeout:
This seems to me that it has been timed out for waiting in 60s if I am not mistaken by the last part of the logs 🤔 . |
Sure, that's a good start but we should look into why the pipeline is timing out waiting for 60s - the actual task only seems to echo hello so its really weird that it will take a entire minute to finish running. Some other oddities I noticed in the pipeline is that we are referencing a workspace with a secret but that is never used (is the secret even present?). Also, some of the tasks/pipelines have references to pipeline resources - shouldn't they fail to get created? |
This commit refactors the yamls in the conversion test to aovid flake where the TaskRun and the PipelineRun could run forever: - remove the `resources` related codes - change the workspace usage that are not present - updates the params specifications
28885c9
to
9508b95
Compare
Thanks @dibyom , I've updated the PR, I've mistaken that it could be longer than 60s while having the previous functionalities before we remove all the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
This commit refactors the yamls in the conversion test to aovid flake
where the TaskRun and the PipelineRun could run forever:
resources
related codesfixes: #6672
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes