Enable beta features by default #6732

lbernick · 2023-05-26T18:25:51Z

When users decide to upgrade to v1 APIs, they may not be aware they are using beta features. If they are using the default value ("stable") of "enable-api-fields", any beta features they're using will work in beta APIs, but break when when move to v1 APIs.

This commit changes the default value of "enable-api-fields" to "beta", to ensure beta features continue to work by default when users change API versions. Independently, we plan to decouple API versioning from feature versioning (#6592).

This commit will also help avoid breakages when swapping our storage version to v1 due to the issue described here.

This commit is not backwards compatible.

Related: #6616

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: "enable-api-fields" is set to "beta" by default. If you are using v1 APIs and would like to use only stable features, modify the "feature-flags" configmap in the "tekton-pipelines" namespace to set "enable-api-fields" to "stable". Example command: kubectl patch cm feature-flags -n tekton-pipelines -p '{"data":{"enable-api-fields":"stable"}}'
If you are using v1beta1 APIs, no action is needed.

tekton-robot · 2023-05-26T18:31:05Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-05-26T18:33:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

JeromeJu · 2023-05-26T19:08:19Z

/assign

lbernick · 2023-05-26T20:26:56Z

/hold
need to fix integration tests

tekton-robot · 2023-05-30T14:55:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-05-30T14:57:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-05-30T14:58:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-05-30T15:19:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-05-30T15:21:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

lbernick · 2023-05-30T16:32:21Z

error was:

2023/05/30 15:16:28 process.go:153: Running: gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-2 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1663564572834926592 --cluster-version=1.25.8-gke.500 tpipeline-e2e-cls1663564572834926592
Default change: VPC-native is the default mode during cluster creation for versions greater than 1.21.0-gke.1500. To create advanced routes based clusters, please pass the `--no-enable-ip-alias` flag
Default change: During creation of nodepools or autoscaling configuration changes for cluster versions greater than 1.24.1-gke.800 a default location policy is applied. For Spot and PVM it defaults to ANY, and for all other VM kinds a BALANCED policy is used. To change the default values use the `--location-policy` flag.
Note: Your Pod address range (`--cluster-ipv4-cidr`) can accommodate at most 1008 node(s).
ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400, message=Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.24+ clusters as Dockershim has been removed in Kubernetes v1.24.
2023/05/30 15:16:31 process.go:155: Step 'gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-2 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1663564572834926592 --cluster-version=1.25.8-gke.500 tpipeline-e2e-cls1663564572834926592' finished in 3.575932749s
2023/05/30 15:16:31 main.go:319: Something went wrong: starting e2e cluster: error creating cluster: error during gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-2 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1663564572834926592 --cluster-version=1.25.8-gke.500 tpipeline-e2e-cls1663564572834926592: exit status 1

test pass locally-- if retesting passes I will file an issue
/retest

lbernick · 2023-05-30T19:39:52Z

error was:

2023/05/30 15:16:28 process.go:153: Running: gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-2 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1663564572834926592 --cluster-version=1.25.8-gke.500 tpipeline-e2e-cls1663564572834926592
Default change: VPC-native is the default mode during cluster creation for versions greater than 1.21.0-gke.1500. To create advanced routes based clusters, please pass the `--no-enable-ip-alias` flag
Default change: During creation of nodepools or autoscaling configuration changes for cluster versions greater than 1.24.1-gke.800 a default location policy is applied. For Spot and PVM it defaults to ANY, and for all other VM kinds a BALANCED policy is used. To change the default values use the `--location-policy` flag.
Note: Your Pod address range (`--cluster-ipv4-cidr`) can accommodate at most 1008 node(s).
ERROR: (gcloud.beta.container.clusters.create) ResponseError: code=400, message=Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.24+ clusters as Dockershim has been removed in Kubernetes v1.24.
2023/05/30 15:16:31 process.go:155: Step 'gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-2 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1663564572834926592 --cluster-version=1.25.8-gke.500 tpipeline-e2e-cls1663564572834926592' finished in 3.575932749s
2023/05/30 15:16:31 main.go:319: Something went wrong: starting e2e cluster: error creating cluster: error during gcloud beta container clusters create --quiet --enable-autoscaling --min-nodes=1 --max-nodes=3 --scopes=cloud-platform --no-issue-client-certificate --project=tekton-prow-2 --region=us-central1 --machine-type=n1-standard-4 --image-type=cos --num-nodes=1 --network=tpipeline-e2e-net1663564572834926592 --cluster-version=1.25.8-gke.500 tpipeline-e2e-cls1663564572834926592: exit status 1

test pass locally-- if retesting passes I will file an issue /retest

This happened because our prow config hard-codes the file "test/e2e-tests-kind-prow.env" which I attempted to rename. reverted.

tekton-robot · 2023-05-30T19:45:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-05-30T19:48:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-05-30T20:01:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-05-30T20:05:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

JeromeJu

Thanks Lee!
shall we also change to beta at prow.env for testing the defaults deployed?

JeromeJu

Thanks Lee!
shall we also change to beta at prow.env for testing the defaults deployed?

lbernick · 2023-06-05T14:00:44Z

Thanks Lee! shall we also change to beta at prow.env for testing the defaults deployed?

I think we already have 3 e2e configurations for prow, one for each feature gate, so I'm not sure we need changes. The file e2e-tests-kind.env doesn't seem to be used anywhere in our prow config.

When users decide to upgrade to v1 APIs, they may not be aware they are using beta features. If they are using the default value ("stable") of "enable-api-fields", any beta features they're using will work in beta APIs, but break when when move to v1 APIs. This commit changes the default value of "enable-api-fields" to "beta", to ensure beta features continue to work by default when users change API versions. Independently, we plan to decouple API versioning from feature versioning. This commit is not backwards compatible.

tekton-robot · 2023-06-05T16:44:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-06-05T16:46:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/workspace_validation.go	100.0%	97.6%	-2.4

tekton-robot · 2023-06-08T13:29:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

afrittoli

Thanks for this.
Would it make sense to deprecate the beta default value right away (it can be in a different PR) and setting a date by when we will switch back to stable as default?

As discussed, I'd love to see the feature flag decoupled from the API version in future.
/lgtm

afrittoli

Thanks for this.
Would it make sense to deprecate the beta default value right away (it can be in a different PR) and setting a date by when we will switch back to stable as default?

As discussed, I'd love to see the feature flag decoupled from the API version in future.
/lgtm

lbernick · 2023-06-08T14:56:56Z

Thanks for this. Would it make sense to deprecate the beta default value right away (it can be in a different PR) and setting a date by when we will switch back to stable as default?

I think this is worth a separate discussion. We'd need to find some way to resolve the issue referenced when using "stable" as the default. I also think "beta" is a reasonable default anyway: k8s enables beta features by default. My preferred solution is per-feature flags.

As discussed, I'd love to see the feature flag decoupled from the API version in future.

👍 , this is causing a lot of problems tbh

tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels May 26, 2023

tekton-robot requested review from pritidesai and vdemeester May 26, 2023 18:25

tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 26, 2023

tekton-robot assigned JeromeJu May 26, 2023

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023

lbernick force-pushed the beta-by-default branch 2 times, most recently from acd2a68 to d857574 Compare May 30, 2023 14:49

lbernick force-pushed the beta-by-default branch from d857574 to d3993d3 Compare May 30, 2023 15:14

lbernick added this to the Pipelines v0.49 milestone May 30, 2023

lbernick force-pushed the beta-by-default branch from d3993d3 to d7fc3eb Compare May 30, 2023 19:38

lbernick removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023

lbernick assigned vdemeester, afrittoli and dibyom May 30, 2023

lbernick force-pushed the beta-by-default branch from d7fc3eb to 1ff58d0 Compare May 30, 2023 19:54

lbernick mentioned this pull request Jun 2, 2023

Change the Storage Version to V1 Types #6444

Merged

7 tasks

JeromeJu approved these changes Jun 5, 2023

View reviewed changes

lbernick force-pushed the beta-by-default branch from 1ff58d0 to 5108155 Compare June 5, 2023 16:38

vdemeester approved these changes Jun 8, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023

afrittoli reviewed Jun 8, 2023

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023

afrittoli reviewed Jun 8, 2023

View reviewed changes

tekton-robot merged commit 6b243df into tektoncd:main Jun 8, 2023

This was referenced Jul 20, 2023

Default enable-api-fields value for opt-in features once feature and API versioning are decoupled #6948

Closed

[TEP-0138]: Decouple API and Feature Versioning Proposal tektoncd/community#1034

Merged

Richard87 mentioned this pull request Nov 20, 2023

Upgrade Tekton to newer version equinor/tekton-helm-chart#1

Closed

JordanGoasdoue mentioned this pull request Jul 10, 2024

Upgrade Tekton to latest version jenkins-x/jx#8683

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable beta features by default #6732

Enable beta features by default #6732

lbernick commented May 26, 2023 •

edited

Loading

tekton-robot commented May 26, 2023

tekton-robot commented May 26, 2023

JeromeJu commented May 26, 2023

lbernick commented May 26, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

lbernick commented May 30, 2023

lbernick commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

JeromeJu left a comment

JeromeJu left a comment

lbernick commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 8, 2023

afrittoli left a comment

afrittoli left a comment

lbernick commented Jun 8, 2023

Enable beta features by default #6732

Enable beta features by default #6732

Conversation

lbernick commented May 26, 2023 • edited Loading

Submitter Checklist

Release Notes

tekton-robot commented May 26, 2023

tekton-robot commented May 26, 2023

JeromeJu commented May 26, 2023

lbernick commented May 26, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

lbernick commented May 30, 2023

lbernick commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

tekton-robot commented May 30, 2023

JeromeJu left a comment

Choose a reason for hiding this comment

JeromeJu left a comment

Choose a reason for hiding this comment

lbernick commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 5, 2023

tekton-robot commented Jun 8, 2023

afrittoli left a comment

Choose a reason for hiding this comment

afrittoli left a comment

Choose a reason for hiding this comment

lbernick commented Jun 8, 2023

lbernick commented May 26, 2023 •

edited

Loading