Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add PROBES_PORT environment variable and update targetPorts for existing services #6739

Merged
merged 1 commit into from
Jun 14, 2023
Merged

chore: Add PROBES_PORT environment variable and update targetPorts for existing services #6739

merged 1 commit into from
Jun 14, 2023

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented May 30, 2023 •
edited
Loading

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label May 30, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 30, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kahirokunn / name: kahirokunn (e34e7d4)

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2023
@tekton-robot
Copy link
Collaborator

Hi @kahirokunn. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kahirokunn
Copy link
Contributor Author

/kind documentation

@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels May 30, 2023
@kahirokunn kahirokunn changed the title chore: use named port chore: Add PROBES_PORT environment variable and update targetPorts for existing services May 30, 2023
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2023
@lbernick
Copy link
Member

/ok-to-test
@kahirokunn thanks for your PR! Could you please add a commit message body/PR description explaining the reason for these changes? I wouldn't expect this to be user facing, so no release note is needed.

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2023
Yongxuanzhang
Yongxuanzhang reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the integrations are failing, not sure if it is due to the port setting?
And could you add PR description as well? Thanks!

config/webhook.yaml Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 6, 2023
@kahirokunn
Copy link
Contributor Author

@lbernick
I described the reason in the commit message.
How about now?

@lbernick
Copy link
Member

lbernick commented Jun 7, 2023

It sounds like you are trying to change the probes port value for the webhook on your cluster post-installation and I'm curious why? what is probes port used for?

@kahirokunn
Copy link
Contributor Author

@lbernick

There are cases like the following:

  1. EKS worker clusters are built with vxlan (e.g., cilium)
  2. Control planes are outside of vxlan (e.g., EKS)

In such configurations, to pass a webhook from the control plane to a Pod, one of the following procedures needs to be performed:

  1. Enable hostnetwork for the Pod
  2. Use a NodePort Service

If you choose 1. Enable hostnetwork for the Pod, all ports will be exposed on the node, causing port conflicts, and you will need to manage the ports of all Pods.

However, even if it is not such a case, it is less confusing for the reader to either fully express all environment variables or not express any at all in the yaml, rather than just partially expressing which environment variables can be changed with some settings.

@lbernick
Copy link
Member

lbernick commented Jun 8, 2023

SGTM! would you mind adding that context to your commit message and pr description? Thanks!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@Yongxuanzhang
Copy link
Member

There should be a release section in your PR description, you could check out other PRs and add it to remove the release-note-label-needed

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 14, 2023
@kahirokunn
chore: Add PROBES_PORT environment variable and update targetPorts fo…
e34e7d4 
…r tekton-pipelines-webhook services

1. EKS worker clusters are built with vxlan (e.g., cilium)
2. Control planes are outside of vxlan (e.g., EKS)

In such configurations, to pass a webhook from the control plane to a Pod, one of the following procedures needs to be performed:

1. Enable hostnetwork for the Pod
2. Use a NodePort Service

If you choose `1. Enable hostnetwork for the Pod`, all ports will be exposed on the node, causing port conflicts, and you will need to manage the ports of all Pods.

However, even if it is not such a case, it is less confusing for the reader to either fully express all environment variables or not express any at all in the yaml, rather than just partially expressing which environment variables can be changed with some settings.

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@kahirokunn
Copy link
Contributor Author

@lbernick What about the current commit message?

@kahirokunn
Copy link
Contributor Author

@Yongxuanzhang thx. done

@lbernick
Copy link
Member

lbernick commented Jun 14, 2023 •
edited
Loading

commit message looks great, thanks! I'll let Yongxuan leave an lgtm

@Yongxuanzhang
Copy link
Member

Thanks!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@tekton-robot tekton-robot merged commit f0f5646 into tektoncd:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@khrm khrm khrm left review comments

@dibyom dibyom Awaiting requested review from dibyom

@lbernick lbernick Awaiting requested review from lbernick

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kahirokunn @tekton-robot @lbernick @Yongxuanzhang @khrm