[TEP-0091] add more no error test cases for taskrun and pipelinerun #6754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
tekton-robot
added
the
size/L
Yongxuanzhang
commented
May 31, 2023
| }, | ||
| }, | ||
| } | ||
| cms := []*corev1.ConfigMap{ |
There was a problem hiding this comment.
this code block is just move the previous test code into the for loop, and use the noMatchPolicy and verificationPolicies from the tests
lbernick
approved these changes
Jun 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
6 tasks
Yongxuanzhang
force-pushed
the
missing-tests
branch
from
0220896
to
aa16dd1
Compare
Yongxuanzhang
force-pushed
the
missing-tests
branch
from
aa16dd1
to
0ff0263
Compare
This commit adds 3 more cases when the trusted resources doesn't fail the run. They are 1) no match policies and feature flag is set to ignore 2) no match policies and feature flag is set to warn 3) only warn mode policies fail. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
Yongxuanzhang
force-pushed
the
missing-tests
branch
from
0ff0263
to
172f81b
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit adds 3 more cases when the trusted resources doesn't fail the run. They are 1) no match policies and feature flag is set to ignore 2) no match policies and feature flag is set to warn 3) only warn mode policies fail.
no functional change.
/kind misc
Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes